Page MenuHomePhabricator
Create Task
Maniphest T114417

Fatal error: Invalid operand type was used: cannot perform this operation with arrays in /srv/mediawiki/php-master/extensions/PageImages/ApiQueryPageImages.php on line 39
Closed, ResolvedPublic
Actions

Description

On Beta Cluster Search suggestions are not displayed in Search field.

GET http://en.wikipedia.beta.wmflabs.org/w/api.php?action=opensearch&format=json&search=Talk%3AET&namespace=0&limit=10&suggest=true 503 
(Service Unavailable)jQuery.ajaxTransport.options.send @ load.php?
debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=HslbnM5S:140jQuery.extend.ajax @ load.php?
debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=HslbnM5S:13
4mw.loader.implement.mw.Api.ajax @ VM5414:36mw.loader.implement.mw.Api.get @ 
VM5414:35mw.loader.implement.mw.searchSuggest.request @ 
VM5417:373mw.loader.implement.$.suggestions.fetch @ VM5417:376maybeFetch @ VM5417:363

https://logstash-beta.wmflabs.org/#/dashboard/elasticsearch/fatalmonitor displays
Fatal error: Invalid operand type was used: cannot perform this operation with arrays in /srv/mediawiki/php-master/extensions/PageImages/ApiQueryPageImages.php on line 39

Details

SubjectRepoBranchLines +/-
Include foreign files in ApiQueryPageImagesmediawiki/extensions/PageImagesmaster+134 -4
Revert "Include foreign files in ApiQueryPageImages"mediawiki/extensions/PageImagesmaster+4 -39
Customize query in gerrit

Revisions and Commits

rEPIM extension-PageImages
rEPIMe150f90989d3 Revert "Revert "Include foreign files in ApiQueryPageImages""

Related Objects

Event Timeline

Etonkovidova created this task.Oct 1 2015, 8:20 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: Beta-Cluster-Infrastructure, discovery-system.
Etonkovidova subscribed.
Restricted Application added subscribers: Luke081515, Aklapper. · View Herald TranscriptOct 1 2015, 8:20 PM
greg renamed this task from [betalabs] Search suggestions are not displayed: 503 Error to [betacluster] Search suggestions are not displayed: 503 Error.Oct 1 2015, 8:53 PM
greg updated the task description. (Show Details)
greg set Security to None.
greg edited projects, added Discovery-ARCHIVED; removed discovery-system.
Etonkovidova updated the task description. (Show Details)Oct 1 2015, 9:02 PM
greg renamed this task from [betacluster] Search suggestions are not displayed: 503 Error to Fatal error: Invalid operand type was used: cannot perform this operation with arrays in /srv/mediawiki/php-master/extensions/PageImages/ApiQueryPageImages.php on line 39.Oct 1 2015, 9:14 PM
greg triaged this task as Unbreak Now! priority.
greg added a project: PageImages.
greg subscribed.

This is causing lots of 503s in Beta Cluster, setting to UBN!

See it here: https://logstash-beta.wmflabs.org/#dashboard/temp/AVAlQp9na1EjumVdsyEF

greg mentioned this in T114429: 503 flooding in Beta Cluster, cant add any link in VisualEditor.Oct 1 2015, 9:16 PM
greg added a comment.Oct 1 2015, 9:18 PM

Started at 18:30 UTC today.

greg mentioned this in T98791: Foreign files don't get page images.Oct 1 2015, 9:20 PM
greg added subscribers: phuedx, Jdlrobson.
Krenair subscribed.Oct 1 2015, 9:22 PM
greg assigned this task to Jdlrobson.Oct 1 2015, 9:23 PM

Most likely caused by https://gerrit.wikimedia.org/r/#/c/242835/ merged by Jon. Assigning to him

gerritbot subscribed.Oct 1 2015, 9:23 PM

Change 243026 had a related patch set uploaded (by Legoktm):
Revert "Include foreign files in ApiQueryPageImages"

https://gerrit.wikimedia.org/r/243026

gerritbot added a project: Patch-For-Review.Oct 1 2015, 9:23 PM
greg added a project: Gather.Oct 1 2015, 9:24 PM
gerritbot added a comment.Oct 1 2015, 9:42 PM

Change 243026 merged by jenkins-bot:
Revert "Include foreign files in ApiQueryPageImages"

https://gerrit.wikimedia.org/r/243026

Legoktm mentioned this in rMEXTd0cdcc380bdd: Updated mediawiki/extensions Project: mediawiki/extensions/PageImages….Oct 1 2015, 9:43 PM
Legoktm mentioned this in rEPIM1690d99e369d: Revert "Include foreign files in ApiQueryPageImages".Oct 1 2015, 9:45 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Oct 1 2015, 10:00 PM
greg added a subscriber: Ryasmeen.Oct 1 2015, 10:06 PM

@Etonkovidova / @Ryasmeen can you still reproduce this problem on Beta Cluster?

Jdforrester-WMF merged a task: T114429: 503 flooding in Beta Cluster, cant add any link in VisualEditor.Oct 1 2015, 10:12 PM
Jdforrester-WMF subscribed.
gerritbot added a comment.Oct 2 2015, 9:09 AM

Change 243124 had a related patch set uploaded (by Phuedx):
Revert "Revert "Include foreign files in ApiQueryPageImages""

https://gerrit.wikimedia.org/r/243124

phuedx claimed this task.Oct 2 2015, 9:10 AM
phuedx added a project: Reading-Web-Sprint-57-The Fifth Element.
phuedx moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-57-The Fifth Element board.
phuedx added a comment.Oct 2 2015, 9:13 AM

I've brought this into the Reading Web team's current sprint so that it's tested for when reviewing 243124. Do bear in mind that you'll need to add the following to your LocalSettings.php:

$wgPageImagesExpandOpenSearchXml = true;
Jdlrobson removed a project: Patch-For-Review.Oct 2 2015, 3:19 PM
greg added a comment.Oct 2 2015, 3:40 PM

(it has a patch for review)

hashar moved this task from To Triage to In-progress on the Beta-Cluster-Infrastructure board.Oct 3 2015, 7:57 AM
greg mentioned this in T114486: Create #beta-cluster-reproducible tag and rename #beta-cluster to #beta-cluster-infrastructure.Oct 4 2015, 2:59 AM
greg edited projects, added Beta-Cluster-reproducible; removed Beta-Cluster-Infrastructure.Oct 5 2015, 4:37 PM
greg added a project: Patch-For-Review.Oct 5 2015, 4:43 PM
Jdlrobson lowered the priority of this task from Unbreak Now! to High.Oct 5 2015, 5:41 PM
Jdlrobson unsubscribed.Oct 5 2015, 7:26 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-57-The Fifth Element board.Oct 6 2015, 10:05 PM
gerritbot added a comment.Oct 6 2015, 10:12 PM

Change 243124 merged by jenkins-bot:
Include foreign files in ApiQueryPageImages

https://gerrit.wikimedia.org/r/243124

phuedx mentioned this in rEPIM56243a6c655e: Include foreign files in ApiQueryPageImages.Oct 6 2015, 10:12 PM
phuedx mentioned this in rMEXT87c87071f53e: Updated mediawiki/extensions Project: mediawiki/extensions/PageImages….
Jdlrobson closed this task as Resolved.Oct 6 2015, 11:17 PM
Jdlrobson subscribed.

Not seeing any fatals yet given the recently re-merged change. Will keep monitoring.

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-57-The Fifth Element board.Oct 7 2015, 4:55 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)).Oct 7 2015, 7:02 PM
phuedx added a commit: rEPIMe150f90989d3: Revert "Revert "Include foreign files in ApiQueryPageImages"".Apr 28 2016, 2:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL