Page MenuHomePhabricator
Create Task
Maniphest T11446

Closing php tag ?> missing in generated LocalSettings.php
Closed, InvalidPublic
Actions

Description

I just installed v1.10 from SVN HEAD and the config script omits the closing ?>
tag at the end of the file.

I'm not sure if it matters (I guess PHP closes it implicitly at the end of file)
but I will post a quick patch for completeness.

Version: 1.10.x
Severity: normal
Platform: PC

Details

Reference
bz9446

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:36 PM
• bzimport added a project: MediaWiki-Installer.
• bzimport set Reference to bz9446.
• bzimport added a subscriber: Unknown Object (MLST).
HappyDog created this task.Mar 29 2007, 8:44 AM
HappyDog added a comment.Mar 29 2007, 8:44 AM

Created attachment 3397
Patch - closing ?> now present.

Attached:

patch631 BDownload

• brion added a comment.Mar 29 2007, 2:36 PM

This was done on purpose, so people don't accidentally add text after it (a
frequent problem).

HappyDog added a comment.Mar 29 2007, 9:22 PM

Ah - I see. Clever.

One day I'll submit a patch that's actually useful... :-)

Raymond added a comment.Jun 6 2007, 7:06 PM
  • Bug 10174 has been marked as a duplicate of this bug. ***
• mmodell changed the task status from Invalid to Resolved by committing rPHDEP81dc55d04fec: Updated git submodules.Sep 7 2016, 10:17 PM
• mmodell added a commit: rPHDEP81dc55d04fec: Updated git submodules.
• mmodell changed the task status from Resolved to Invalid.Sep 7 2016, 11:16 PM
• mmodell removed a commit: rPHDEP81dc55d04fec: Updated git submodules.Sep 7 2016, 11:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL