Page MenuHomePhabricator
Create Task
Maniphest T114480

Render an error in generated content on closing the inspector
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Currently, if an extension inspector is closed while there is an error in the generated content, the last valid rendering remains, with no visible prompt that there is an error until after the page is saved. The only reason for not rendering an error while the inspector is open is to prevent the inspector from jumping around. So errors should be rendered once the inspector is closed.

Details

SubjectRepoBranchLines +/-
Ensure full error message is shown when inspector is closedmediawiki/extensions/VisualEditormaster+2 -0
Pass staging state through Document#commit to ve.dm.Node update eventVisualEditor/VisualEditormaster+30 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Oct 2 2015, 1:05 PM
Tchanders assigned this task to Esanders.
Tchanders raised the priority of this task from to Needs Triage.
Tchanders updated the task description. (Show Details)
Tchanders added a project: VisualEditor.
Tchanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2015, 1:05 PM
Tchanders mentioned this in T114453: [Regression pre-wmf.2] Wrong LaTeX formula still renders as correct one after editing.Oct 2 2015, 1:08 PM
gerritbot subscribed.Oct 2 2015, 1:09 PM

Change 243166 had a related patch set uploaded (by Esanders):
Pass staging state through Document#commit to ve.dm.Node update event

https://gerrit.wikimedia.org/r/243166

gerritbot added a project: Patch-For-Review.Oct 2 2015, 1:09 PM
gerritbot added a comment.Oct 2 2015, 1:11 PM

Change 243167 had a related patch set uploaded (by Esanders):
Ensure full error message is show when inspector is closed

https://gerrit.wikimedia.org/r/243167

Jdforrester-WMF triaged this task as Medium priority.Oct 3 2015, 12:53 AM
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
gerritbot added a comment.Oct 5 2015, 4:15 PM

Change 243166 merged by jenkins-bot:
Pass staging state through Document#commit to ve.dm.Node update event

https://gerrit.wikimedia.org/r/243166

Esanders mentioned this in rGVED5f2402b385e9: Pass staging state through Document#commit to ve.dm.Node update event.Oct 5 2015, 4:15 PM
gerritbot added a comment.Oct 5 2015, 5:18 PM

Change 243167 merged by jenkins-bot:
Ensure full error message is shown when inspector is closed

https://gerrit.wikimedia.org/r/243167

Jdforrester-WMF mentioned this in rEVED3f2a885e3ecc: Ensure full error message is shown when inspector is closed.Oct 5 2015, 5:18 PM
Jdforrester-WMF closed this task as Resolved.Oct 5 2015, 5:21 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)), VisualEditor-EditingTools; removed Patch-For-Review.
Ryasmeen added a project: Verified.Oct 5 2015, 7:46 PM
Jdforrester-WMF added a parent task: T114453: [Regression pre-wmf.2] Wrong LaTeX formula still renders as correct one after editing.Oct 6 2015, 12:03 AM
Jdforrester-WMF added a parent task: T118616: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability.Nov 14 2015, 12:25 AM
Jdforrester-WMF raised the priority of this task from Medium to High.Nov 20 2015, 7:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL