Page MenuHomePhabricator

[Regression pre-wmf.2] Red highlight appearing instead of blue on selecting an image
Closed, ResolvedPublic1 Story Points

Description

When I select an image, the highlight on selection is red instead of blue .

Event Timeline

Ryasmeen created this task.Oct 2 2015, 8:16 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen added a subscriber: Ryasmeen.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2015, 8:16 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.Oct 2 2015, 9:14 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

This is weird, but is it really UBN?

This comes from .ve-ce-focusableNode-highlight-error

generatedContentsValid starts off false, and is never changed for ve.ce.MWImageNode instances because they don't call their parent render method (seems they generate a URL instead of DOM elements?)

This is weird, but is it really UBN?

Yeah, it's my screw-up for merging something without spotting this. :-)

J.

Esanders assigned this task to Tchanders.Oct 3 2015, 8:17 PM

Change 243499 had a related patch set uploaded (by Esanders):
Follow-up I553e31: Don't show error for non-rendered GCNs

https://gerrit.wikimedia.org/r/243499

Esanders claimed this task.Oct 4 2015, 11:57 AM

Change 243499 merged by jenkins-bot:
Follow-up I553e31: Don't show error for non-rendered GCNs

https://gerrit.wikimedia.org/r/243499