Page MenuHomePhabricator

Allow self-reviewing changes; make test plan optional
Closed, DuplicatePublic

Description

Please can you allow users of own changes to be able to review there own code like they can on gerrit.

Also please make test plan optional.

Please see https://phabricator.wikimedia.org/D7.

Event Timeline

Paladox created this task.Oct 3 2015, 2:12 PM
Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added projects: Phabricator, Differential.
Paladox added a subscriber: Paladox.
Restricted Application added subscribers: scfc, Aklapper. · View Herald TranscriptOct 3 2015, 2:12 PM
Paladox updated the task description. (Show Details)Oct 3 2015, 2:12 PM
Paladox set Security to None.
Aklapper renamed this task from Some suggestions for differential in phabricator to Allow self-reviewing changes; make test plan optional.Oct 4 2015, 9:21 AM
Aklapper removed a project: Phabricator.

Feature requests need to include reasons why something is wanted. Please provide clear reasons, always.

Sorry.

Ok a reason to do that is because some users may be the only one editing the code for the repo and so need to review there own code like they can in gerrit.

For test plan not every repo needs a test plan and I doint think we used it on gerrit.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 4 2015, 5:50 AM
greg added a subscriber: greg.Nov 4 2015, 7:33 PM

Just to be explicit: You can self-merge and push changes already (if you have push permissions, obviously). You're right though, I don't see a way for the diff author to self-review their own diff other than by just leaving a comment. This is discussed more in-depth in T138.

The making of test plan optional per repository was discussed upstream at https://secure.phabricator.com/T9331 and is closed as won't fix.

As there does not seem to be anything here not already discussed in T138 I will close this as a duplicate of it.

mmodell added a subscriber: mmodell.Nov 5 2015, 8:54 AM

I already made test plan optional.

Ricordisamoa added a subscriber: Ricordisamoa.