Page MenuHomePhabricator

Maximum height of the link editor should take into account the toolbar height too
Closed, ResolvedPublic8 Estimate Story Points

Description

When the link dialog includes many suggested links, it expands so much that the top and bottom of the dialog are thrown out of the visible part of the page.
Thus the dialog control buttons are accesible only by scrolling the page with the mouse wheel.

Details

Related Gerrit Patches:
VisualEditor/VisualEditor : masterLimit the height of desktop-context popups

Event Timeline

geraki created this task.Oct 4 2015, 6:10 PM
geraki raised the priority of this task from to Needs Triage.
geraki updated the task description. (Show Details)
geraki added a subscriber: geraki.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2015, 6:10 PM
Spage triaged this task as High priority.Oct 5 2015, 6:23 PM
Spage added a subscriber: Spage.

I'm seeing this too on mw.org. The list wasn't that long before, it fit within the window.

I'm also having the problem that the big list of suggested links don't go away when I click one. The input area updates to the link I clicked, but I have to set the input focus to it and then press [Enter] to make the list go away. However, the second time I bring up the link dialog, it works better.

Firefox 41 on Ubuntu 15.04.

Jdforrester-WMF renamed this task from The link dialog expands over the visible part of the page to Maximum height of the link editor should take into account the toolbar height too.Oct 5 2015, 6:39 PM
Jdforrester-WMF lowered the priority of this task from High to Medium.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF added a subscriber: Esanders.
Jdforrester-WMF edited a custom field.

Change 254195 had a related patch set uploaded (by DLynch):
Limit the height of fragment inspectors

https://gerrit.wikimedia.org/r/254195

Jdforrester-WMF raised the priority of this task from Medium to High.Nov 20 2015, 8:05 PM

Change 254195 merged by jenkins-bot:
Limit the height of desktop-context popups

https://gerrit.wikimedia.org/r/254195