Page MenuHomePhabricator
Create Task
Maniphest T114617

Track the number of identifier properties on an item in page_props
Closed, ResolvedPublic
Actions

Description

In T95287 we'll get a new identifier datatype for properties. In the page_props table we track several attributes of a page like the number of claims (wb-claims) and the number of sitelinks (wb-sitelinks). Would be nice to track the number of identifier properties on an item like the number of sitelinks. How to count exactly I'm not sure. One option is to count the number of P identifiers, other option is to count the total of number of claims. If for some reason the same identifier property is used multiple times on an item, the results will differ. I would probably go for the second option (number of claims), because that's closer to how wb-claims counts.

This page_prop could be used in a similar way as wb-sitelinks: To rank items and to suggest items to work on.

Details

SubjectRepoBranchLines +/-
Add wb-identifiers field to page_propsmediawiki/extensions/Wikibasemaster+199 -2
[WIP] Add tests for adding wb-identifiers to page_propsmediawiki/extensions/Wikibasemaster+32 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Multichill created this task.Oct 4 2015, 7:39 PM
Multichill raised the priority of this task from to Needs Triage.
Multichill updated the task description. (Show Details)
Multichill added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
Multichill subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2015, 7:39 PM
Multichill added a subtask: T95287: [Epic] better handling of identifiers in the UI.Oct 4 2015, 7:39 PM
hoo subscribed.Oct 4 2015, 9:00 PM
Multichill edited subtasks, added: T95682: [Task] Add a new datatype for identifiers; removed: T95287: [Epic] better handling of identifiers in the UI.Nov 12 2015, 8:26 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 12 2015, 8:26 PM
hoo closed subtask T95682: [Task] Add a new datatype for identifiers as Resolved.Dec 20 2015, 1:11 AM
Multichill added a comment.Feb 21 2016, 2:12 PM

Bump. Now that we have identifiers on Wikidata it would be really nice to have this.

matej_suchanek added a parent task: T144476: [feature request] add count of external-ids to rdf (Wikidata).Sep 1 2016, 4:04 PM
Esc3300 subscribed.Sep 5 2016, 1:04 PM

Looks like I created a (partial) duplicate with T144476 . Still, this could be on rdf and in the pp table.

thiemowmde triaged this task as Lowest priority.Sep 5 2016, 2:52 PM
Lydia_Pintscher raised the priority of this task from Lowest to Low.Sep 8 2016, 7:14 PM
Multichill mentioned this in T144476: [feature request] add count of external-ids to rdf (Wikidata).Dec 5 2016, 7:16 PM
Multichill added a comment.Dec 5 2016, 10:27 PM

This task blocks T114617

Lydia_Pintscher added subscribers: aude, daniel, Lydia_Pintscher.Dec 6 2016, 9:34 AM

@aude, @daniel, @hoo: Is there anything fundamentally different from how we do the same thing for sitelink count already? How much work do you think it'd be to get this added?

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Dec 14 2016, 12:04 PM
Ladsgroup subscribed.Mar 20 2017, 6:09 PM

I've looked into this a little and it seems it's not easily doable. Item->getStatements() returns StatementList which without doing several SQL lookups we can not distinguish statements which their property is of a certain data type.

Ladsgroup added a comment.Mar 20 2017, 6:10 PM

I need to add that I don't know the codebase good enough to give the last call. That's definitely something Daniel or Thiemo should take a look

Multichill added a comment.Mar 20 2017, 6:53 PM
In T114617#3115238, @Ladsgroup wrote:

I've looked into this a little and it seems it's not easily doable. Item->getStatements() returns StatementList which without doing several SQL lookups we can not distinguish statements which their property is of a certain data type.

Link? Why several lookups? Looking at MariaDB [wikidatawiki_p]> SELECT * from wb_property_info LIMIT 1000,100; I get things back like:

1392external-id{"type":"external-id","formatterURL":"http:\/\/www.comicbookdb.com\/creator.php?ID=$1"}

for https://www.wikidata.org/wiki/Property:P1392 . This could be cached so you don't have to hit the database each time and if it's getting parsed anyway, Could also populate the externallinks table if it gets parsed anyway. I wonder how the imagelinks table gets populated. Solution is probably similar.

daniel added a comment.Mar 23 2017, 2:37 PM

@Ladsgroup there is a PropertyDataTypeLookup service. The implementation used in production is based on a cached list of data types, IIRC. That should be even quicker than the query suggested by Multichill.

Ladsgroup added a comment.Mar 31 2017, 8:52 AM

Since gerritbot doesn't work: https://gerrit.wikimedia.org/r/#/c/345809/

Ladsgroup claimed this task.Mar 31 2017, 8:53 AM
Ladsgroup added a project: Wikidata-Former-Sprint-Board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 31 2017, 8:53 AM
Ladsgroup moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.Mar 31 2017, 8:53 AM
Ladsgroup moved this task from Incoming to Blocked on others on the User-Ladsgroup board.
Multichill moved this task from Blocked on others to In progress on the User-Ladsgroup board.Apr 8 2017, 12:09 PM

@Ladsgroup code review was done. Any update on this?

matej_suchanek added a project: Patch-For-Review.Apr 8 2017, 3:17 PM
matej_suchanek moved this task from consider for next sprint to in progress on the Wikidata board.
Ladsgroup added a comment.Apr 9 2017, 7:37 AM

I just got back. The CI tests look complicated and take some time to get it fixed. The main part is done though.

gerritbot subscribed.Apr 10 2017, 12:23 PM

Change 345974 abandoned by Ladsgroup:
[WIP] Add tests for adding wb-identifiers to page_props

Reason:
Done in I53c8a1162fccc2b3f5b4179d9b1d5327decc5ff4

https://gerrit.wikimedia.org/r/345974

Ladsgroup moved this task from In progress to Blocked on others on the User-Ladsgroup board.Apr 12 2017, 6:51 PM
gerritbot added a comment.Apr 19 2017, 10:46 AM

Change 345809 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add wb-identifiers field to page_props

https://gerrit.wikimedia.org/r/345809

Ladsgroup closed this task as Resolved.Apr 19 2017, 10:53 AM
Ladsgroup moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
Ladsgroup moved this task from Blocked on others to Done on the User-Ladsgroup board.
Multichill mentioned this in T163475: Populate the page_props table on Wikidata with wb-identifiers.Apr 20 2017, 5:57 PM
Multichill added a parent task: T163475: Populate the page_props table on Wikidata with wb-identifiers.Apr 20 2017, 6:08 PM
Multichill mentioned this in T194305: Track the number of (unique) references on an item in page_props.May 9 2018, 7:38 PM
Bugreporter mentioned this in T281585: new page property for number of non-identifiers on an item.Apr 30 2021, 3:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL