Page MenuHomePhabricator

nl.wikipedia.org sitenotice not displaying
Closed, ResolvedPublic

Description

The sitenotice on nl.wikipedia.org is malfunctioning. It is supposed to show for everyone, but it does not.

Tested by 6 people:
-Taketa - Shows in explorer when logged in. Does not show in Chrome logged in/out, not in explorer logged out

  • Sjoerddebruin - Shows
  • NDKilla - Does not show in Safari
  • Reception - Does show in Chrome when logged in. All preferences the same as Taketa.
  • Ymnes - Does not show.

Please solve this asap, because the sitenotice is needed this week to announce a writing week. Unknown if this is malfunctioning on all projects or just nl.wikipedia.org.

Event Timeline

Taketa raised the priority of this task from to Needs Triage.
Taketa updated the task description. (Show Details)
Taketa added a project: WMF-General-or-Unknown.
Taketa added a subscriber: Taketa.

Also tested by a user I cannot remember the name of :P. Did work for them.

NDKilla renamed this task from Sitenotice malfunctioning to nl.wikipedia.org sitenotice not displaying.Oct 5 2015, 3:36 PM
NDKilla set Security to None.
NDKilla added a subscriber: NDKilla.
Aklapper triaged this task as High priority.Oct 5 2015, 4:15 PM

This is about https://nl.wikipedia.org/wiki/MediaWiki:Sitenotice I assume.

It does not show in Firefox 41 when I'm not logged in.
But it works for me when being logged in.

When it works for non nlwp users, this could be a issue with the sitenotice id. Please retest, because the edit https://nl.wikipedia.org/w/index.php?title=MediaWiki:Sitenotice_id&diff=next&oldid=45029454 may let it work for you.

Did what you suggested. Does not work. Also people outside nl.wikipedia have issues, like Aklapper above.

I am seeing sitenotice logged in and as anon (other browser)

The sitenotice needs javascript. If javascript is disabled, the sitenotice is not visible. Maybe AdBlocker or NoScript or other AddOns remove the elements from your output.

if you are familiar with html you could go to https://nl.wikipedia.org/wiki/Speciaal:LegePagina
Open the source text in your browser (most right click and than source text)

You should found a line like this:

<div id="siteNotice"><!-- CentralNotice --><script>document.write("\u003Cdiv class=\"mw-dismissable-notice\"\u003E\u003Cdiv class=\"mw-dismissable-notice-close\"\u003E[\u003Ca href=\"#\"\u003Esluiten\u003C/a\u003E]\u003C/div\u003E\u003Cdiv class=\"mw-dismissable-notice-body\"\u003E\u003Cdiv id=\"localNotice\" lang=\"nl\" dir=\"ltr\"\u003E\u003Ctable style=\"width:100%; text-align:center;\"\u003E\n\n\u003Ctr\u003E\n\u003Ctd\u003E \u003Ch3\u003E\u003Cspan class=\"mw-headline\" id=\"De_schrijfweek_Amersfoort_is_begonnen.21\"\u003EDe \u003Ca href=\"/wiki/Wikipedia:Wikiproject/Schrijfweek_Lokaal/Amersfoort\" title=\"Wikipedia:Wikiproject/Schrijfweek Lokaal/Amersfoort\"\u003Eschrijfweek Amersfoort\u003C/a\u003E is begonnen!\u003C/span\u003E\u003C/h3\u003E\n\u003Cp\u003EVan 5 tot en met 11 oktober staat Wikipedia in het teken van Amersfoort. \u003Ca href=\"/wiki/Wikipedia:Wikiproject/Schrijfweek_Lokaal/Amersfoort#Meedoen\" title=\"Wikipedia:Wikiproject/Schrijfweek Lokaal/Amersfoort\"\u003EDoe mee\u003C/a\u003E!\n\u003C/p\u003E\n\u003C/td\u003E\n\u003Ctd\u003E \u003Ca href=\"/wiki/Bestand:Amersfoort_flag_outline.svg\" class=\"image\" title=\"Schrijfweek Amersfoort\"\u003E\u003Cimg alt=\"Schrijfweek Amersfoort\" src=\"//upload.wikimedia.org/wikipedia/commons/thumb/d/dc/Amersfoort_flag_outline.svg/80px-Amersfoort_flag_outline.svg.png\" width=\"80\" height=\"53\" srcset=\"//upload.wikimedia.org/wikipedia/commons/thumb/d/dc/Amersfoort_flag_outline.svg/120px-Amersfoort_flag_outline.svg.png 1.5x, //upload.wikimedia.org/wikipedia/commons/thumb/d/dc/Amersfoort_flag_outline.svg/160px-Amersfoort_flag_outline.svg.png 2x\" data-file-width=\"450\" data-file-height=\"300\" /\u003E\u003C/a\u003E\n\u003C/td\u003E\u003C/tr\u003E\u003C/table\u003E\n\u003C/div\u003E\u003C/div\u003E\u003C/div\u003E");</script></div>

If the line is in the html and not showing, than it is a issue with the browser.
It is not visible in html, that could be a cache issue on server side.

I see <div id="siteNotice"><!-- CentralNotice --><div class="mw-dismissable-notice"><div class="mw-dismissable-notice-close">[<a href="#">sluiten</a>]</div><div class="mw-dismissable-notice-body"><div id="localNotice" lang="nl" dir="ltr"><table style="width:100%; text-align:center;">

<tr>
<td> <h3><span class="mw-headline" id="De_schrijfweek_Amersfoort_is_begonnen.21">De <a href="/wiki/Wikipedia:Wikiproject/Schrijfweek_Lokaal/Amersfoort" title="Wikipedia:Wikiproject/Schrijfweek Lokaal/Amersfoort">schrijfweek Amersfoort</a> is begonnen!</span></h3>
<p>Van 5 tot en met 11 oktober staat Wikipedia in het teken van Amersfoort. <a href="/wiki/Wikipedia:Wikiproject/Schrijfweek_Lokaal/Amersfoort#Meedoen" title="Wikipedia:Wikiproject/Schrijfweek Lokaal/Amersfoort">Doe mee</a>!
</p>
</td>
<td> <a href="/wiki/Bestand:Amersfoort_flag_outline.svg" class="image" title="Schrijfweek Amersfoort"><img alt="Schrijfweek Amersfoort" src="upload.wikimedia.org/wikipedia/commons/thumb/d/dc/Amersfoort_flag_outline.svg/80px-Amersfoort_flag_outline.svg.png" width="80" height="53" srcset="upload.wikimedia.org/wikipedia/commons/thumb/d/dc/Amersfoort_flag_outline.svg/120px-Amersfoort_flag_outline.svg.png 1.5x, //upload.wikimedia.org/wikipedia/commons/thumb/d/dc/Amersfoort_flag_outline.svg/160px-Amersfoort_flag_outline.svg.png 2x" data-file-width="450" data-file-height="300" /></a>
</td></tr></table>

also two other lines mention sitenotice:

});mw.loader.load(["mediawiki.page.startup","mediawiki.legacy.wikibits","ext.centralauth.centralautologin.clearcookie","ext.visualEditor.desktopArticleTarget.init","ext.uls.init","ext.uls.interface","ext.centralNotice.bannerController","skins.vector.js","ext.dismissableSiteNotice"]);

{"pageLanguageCode":"nl","pageLanguageDir":"ltr","usePageImages":true,"usePageDescriptions":true},"wgULSAcceptLanguageList":["nl-nl","nl","en-us","en"],"wgULSCurrentAutonym":"Nederlands","wgCategoryTreePageCategoryOptions":"{\"mode\":0,\"hideprefix\":20,\"showcount\":true,\"namespaces\":false}","wgNoticeProject":"wikipedia","wgNoticeUserData":{"registration":"20080215101521"},"wgVisualEditorToolbarScrollOffset":0,"wgSiteNoticeId":"2.0","wgEchoSeenTime":

Btw, after this change https://nl.wikipedia.org/w/index.php?title=MediaWiki%3AAnonnotice&type=revision&diff=45034632&oldid=43699350 I can now see it in explorer when logged out and when logged in. I can still not see it in Chrome logged in or out.

I too now see this on google chrome, logged in and logged out

Thanks Umherirrender for your help (and to Glaisher on IRC too)!

I can still not see it in Chrome logged in or out.

Did you bypass your browser cache?

@Aklapper, I cleared my browser cache. I cannot see it on chrome. On nl.wikipedia Ymnes says they can see the sitenotice using Windows with Explorer, Safari, Chrome and Firefox, but not with Linux Ubuntu using Firefox, however Epiphany does work, and they cannot see it on their, iPad and iPone, with desktopsite on or off.

Did you disable any add-ons and extensions in your browsers? Did everybody bypass their browser caches?

Aklapper lowered the priority of this task from High to Medium.Oct 6 2015, 10:36 AM

It is not just me, it is not just chrome browser. It is many people. It is several browsers. We need the sitenotice to reach the community this week, with a writing week that is happening right now. Please focus on the software, not on me.

You asked for specific indicators why I think a change was made to the software. The last sitenotice, which was taken down 21 september, showed just fine for me. It worked for everyone. The last sitenotice caused a rush of people to complain about the "flashing sitenotice" after it was clicked away problem. I can only assume someone did something to the software to "fix" the flashing, without effect, which is causing the current problem. No other changes were made during the 2 week period. It cannot be that multiple people have issues on multiple browsers where the exact same action caused no problem only 2 weeks ago.

I am very very annoyed that the sitenotice does not work for some people. I promised the media and politicians who are invited to the meeting this friday for the writing week that Wikipedia would announce it on 5 okt. I make a bad impression now. Some might not come. Also the writing week will produce less articles. This was supposed to be the first writing week, which is to be used to promote next writing weeks. It is all fucked up and someone is to blaim. Someone did something in the last 2 weeks. Please find what it is and fix it.

Actually, we focus on the software .

As you experience the bug, you're in a privileged position to help us to understand the cause.

It's a little like when you go to the doctor and explain to them your symptoms.

Once we'll have determined what triggers this bug on your environment, we'll be able to offer a change to fix it.

Actually, we focus on the software .

As you experience the bug, you're in a privileged position to help us to understand the cause.

It's a little when you go to the doctor and explain to him your symptoms.

Once we'll have determined what triggers this bug on your environment, we'll be able to offer a change to fix it.

If you feel sick and the doctor keeps asking about your mental health, you would get annoyed to. Please focus on the general problem.

As explained before, we focus on the general problem trying to understand on one environment (yours) the root causes.

This is a matter of reproductability. A bug must be reproduced to be able to fix it. So, we need your help to determine how to trigger the bug.

@Taketa can you check whether you've a cookie named dismissSiteNotice in your browser? (You can google to find out how to check the cookies on your browser).

@Taketa can you check whether you've a cookie named dismissSiteNotice in your browser? (You can google to find out how to check the cookies on your browser).

I googled it and checked under Content setting, All cookies and site data. It is not in there.

https://nl.wikipedia.org/w/index.php?title=MediaWiki:Sitenotice_id&diff=45034601&oldid=45029461

The code expects you to have only an integer value on that page. Please remove everything else and (also increment the value to 41, just to be safe). It's currently passing 0 always. I'm not sure if this would fix it but that page definitely contains something that's not expected by the extension.

https://nl.wikipedia.org/w/index.php?title=MediaWiki:Sitenotice_id&diff=45034601&oldid=45029461

The code expects you to have only an integer value on that page. Please remove everything else and (also increment the value to 41, just to be safe). It's currently passing 0 always. I'm not sure if this would fix it but that page definitely contains something that's not expected by the extension.

Done, it now works for me! Thank you.

Yet is stays strange that it worked 2 weeks ago but did not work now. I stay with the fact that someone did something. If it is not stated publicly, then this is bad,

I will now remove the announcement I just made on nl.wikipedia for the community to come here and explain in person how urgent the problem is.

Glaisher claimed this task.

There has been no change to the extension code. You can see for yourself https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/DismissableSiteNotice,n,z

There has been no change to the extension code. You can see for yourself https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/DismissableSiteNotice,n,z

Which leave the question, why did the same thing work dozens of times before and not now. Something changed. If not in this software then something related effecting this. It cannot be chrome, because other browsers experienced problems too. It can only be Wikimedia.

I will now remove the announcement I just made on nl.wikipedia for the community to come here and explain in person how urgent the problem is.

For future reference, only "explaining how urgent the problem is" is not helpful. Providing clear steps and criteria to reproduce is. :)

Thanks to everybody who helped fixing this.

Which leave the question, why did the same thing work dozens of times before and not now. Something changed. If not in this software then something related effecting this. It cannot be chrome, because other browsers experienced problems too. It can only be Wikimedia.

There were two issues here. One was that it wasn't shown to logged-out users at all. This is because of changing the behavior of how Anonnotice works several months ago and no one updated the nlwiki page to reflect this. It was only updated yesterday when you were on IRC and since then logged-out users should be able to see it. Second issue is that the local nlwiki Sitenotice page had content which breaks the extension. So the cookie was always using "0" for the id and the actual cookie never changed since the breaking change to the sitenotice since July. It expires after 30 days so if the sitenotice was renewed after the cookie expires, the new sitenotice will be shown. I don't know what happened in your case because the notice is only supposed to be hidden only if the cookie is present but it's not in your browser. (But theoretically, this would happen because you've an unexpired sitenotice-dismiss cookie in your browser).

Which leave the question, why did the same thing work dozens of times before and not now. Something changed. If not in this software then something related effecting this. It cannot be chrome, because other browsers experienced problems too. It can only be Wikimedia.

There were two issues here. One was that it wasn't shown to logged-out users at all. This is because of changing the behavior of how Anonnotice works several months ago and no one updated the nlwiki page to reflect this. It was only updated yesterday when you were on IRC and since then logged-out users should be able to see it. Second issue is that the local nlwiki Sitenotice page had content which breaks the extension. So the cookie was always using "0" for the id and the actual cookie never changed since the breaking change to the sitenotice since July. It expires after 30 days so if the sitenotice was renewed after the cookie expires, the new sitenotice will be shown. I don't know what happened in your case because the notice is only supposed to be hidden only if the cookie is present but it's not in your browser. (But theoretically, this would happen because you've an unexpired sitenotice-dismiss cookie in your browser).

Thank you for the explanation. That settles my question. And thank you for taking the time to solve this issue and answer my questions with all the patience in the world.