Page MenuHomePhabricator
Create Task
Maniphest T114689

Changes to non-rendered attributes of GeneratedContentNodes don't get saved
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Currently this is just 'id' in Math nodes.

Details

SubjectRepoBranchLines +/-
VE: Move hash changes to the rendering hashmediawiki/extensions/Mathmaster+6 -5
Update VE core submodule to master (363adf2)mediawiki/extensions/VisualEditormaster+30 -36
[BREAKING CHANGE] GeneratedContentNode: Introduce new hash for renderingVisualEditor/VisualEditormaster+30 -3
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Oct 5 2015, 6:00 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki.
Jdforrester-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2015, 6:00 PM
Jdforrester-WMF set Security to None.Oct 5 2015, 6:00 PM
Jdforrester-WMF edited a custom field.
gerritbot subscribed.Oct 5 2015, 6:36 PM

Change 242894 had a related patch set uploaded (by Jforrester):
[BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering

https://gerrit.wikimedia.org/r/242894

gerritbot added a project: Patch-For-Review.Oct 5 2015, 6:36 PM
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.Oct 6 2015, 12:04 AM
gerritbot added a comment.Oct 7 2015, 2:09 AM

Change 242894 merged by jenkins-bot:
[BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering

https://gerrit.wikimedia.org/r/242894

Jdforrester-WMF mentioned this in rGVED63c5f67fc3b8: [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering.Oct 7 2015, 2:10 AM
gerritbot added a comment.Oct 7 2015, 2:40 PM

Change 242895 had a related patch set uploaded (by Jforrester):
VE: Move hash changes to the rendering hash

https://gerrit.wikimedia.org/r/242895

gerritbot added a comment.Oct 7 2015, 3:00 PM

Change 244167 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (363adf2)

https://gerrit.wikimedia.org/r/244167

gerritbot added a comment.Oct 7 2015, 3:12 PM

Change 244167 merged by jenkins-bot:
Update VE core submodule to master (363adf2)

https://gerrit.wikimedia.org/r/244167

Jdforrester-WMF mentioned this in rEVED9fb6977e5205: Update VE core submodule to master (363adf2).Oct 7 2015, 3:13 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)).Oct 7 2015, 7:02 PM
Jdforrester-WMF closed this task as Resolved.Oct 7 2015, 7:17 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
gerritbot added a comment.Oct 7 2015, 7:18 PM

Change 242895 merged by jenkins-bot:
VE: Move hash changes to the rendering hash

https://gerrit.wikimedia.org/r/242895

Diffusion mentioned this in rMEXTf39012e3541c: Updated mediawiki/extensions Project: mediawiki/extensions/Math….Oct 7 2015, 7:18 PM
Jdforrester-WMF mentioned this in rEMAT905a834be2a6: VE: Move hash changes to the rendering hash.Oct 7 2015, 7:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL