Page MenuHomePhabricator
Create Task
Maniphest T114695

Split mediawiki.skinning.interface css files into separate modules
Closed, ResolvedPublic
Actions

Description

Please split the mediawiki.skinning.interface module into separate modules so that an extension can choose which css file to choose not have to load three to use that one css file.

Please see discussion here https://gerrit.wikimedia.org/r/#/c/241471/

Steps to reproduce

Actual results

  • It dosent go to the correct path in the mediawiki core.

Expected results

  • It should be able to add dependence on that one css file instead of three that may have an affect on the css.

Note: Please keep this module mediawiki.skinning.interface so that it dosent break any skins nor have to load three different modules.

Details

SubjectRepoBranchLines +/-
ResourceLoaderSkinModule: Provide optional mediawiki.skinning stylesmediawiki/coremaster+131 -74
Split module mediawiki.skinning.interface into two different modulesmediawiki/coremaster+21 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Paladox created this task.Oct 5 2015, 6:38 PM
Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added projects: MediaWiki-General, MediaWiki-ResourceLoader.
Paladox subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2015, 6:38 PM
Paladox set Security to None.Oct 5 2015, 6:38 PM
Paladox added a subscriber: Florian.

Added @Florian per https://gerrit.wikimedia.org/r/#/c/241471/ who ask me to file a task.

Please remove your self if I should have not added you to this task.

Paladox updated the task description. (Show Details)Oct 5 2015, 6:40 PM
gerritbot subscribed.Oct 5 2015, 6:46 PM

Change 243719 had a related patch set uploaded (by Paladox):
Split module mediawiki.skinning.interface into three different modules

https://gerrit.wikimedia.org/r/243719

gerritbot added a project: Patch-For-Review.Oct 5 2015, 6:46 PM
Krinkle edited projects, added MediaWiki-User-Interface; removed MediaWiki-ResourceLoader, MediaWiki-General.Nov 12 2015, 10:44 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 12 2015, 10:44 PM
Jdlrobson triaged this task as Medium priority.Nov 30 2015, 7:47 PM
Jdlrobson subscribed.
Jdlrobson lowered the priority of this task from Medium to Lowest.Dec 14 2015, 10:13 PM
gerritbot added a comment.Sep 4 2017, 12:40 PM

Change 243719 abandoned by Paladox:
Split module mediawiki.skinning.interface into two different modules

https://gerrit.wikimedia.org/r/243719

gerritbot added a comment.Oct 28 2019, 9:04 PM

Change 546733 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] ResourceLoaderSkinModule is configurable with different features

https://gerrit.wikimedia.org/r/546733

gerritbot added a comment.Nov 8 2019, 4:39 AM

Change 546733 merged by jenkins-bot:
[mediawiki/core@master] ResourceLoaderSkinModule: Provide optional mediawiki.skinning styles

https://gerrit.wikimedia.org/r/546733

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 8 2019, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 8 2019, 5:10 AM
Jdlrobson closed this task as Resolved.Nov 11 2019, 9:19 PM
Jdlrobson claimed this task.

This is now done. The mediawiki.skinning.interface module is now an instance of ResourceLoaderSkinModule::class - any extension or skin (although I heavily recommend the latter) is now able to define it's own module with the ResourceLoaderSkinModule class and pick and choose which "features" it wants to support.

Jdrewniak mentioned this in T240856: [EPIC] New header for desktop improvements project.Dec 16 2019, 1:13 PM
Jdrewniak added a parent task: T240856: [EPIC] New header for desktop improvements project.Dec 16 2019, 2:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL