Page MenuHomePhabricator

Split mediawiki.skinning.interface css files into separate modules
Closed, ResolvedPublic

Description

Please split the mediawiki.skinning.interface module into separate modules so that an extension can choose which css file to choose not have to load three to use that one css file.

Please see discussion here https://gerrit.wikimedia.org/r/#/c/241471/

Steps to reproduce

Actual results

  • It dosent go to the correct path in the mediawiki core.

Expected results

  • It should be able to add dependence on that one css file instead of three that may have an affect on the css.

Note: Please keep this module mediawiki.skinning.interface so that it dosent break any skins nor have to load three different modules.

Event Timeline

Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added a subscriber: Paladox.
Paladox added a subscriber: Florian.

Added @Florian per https://gerrit.wikimedia.org/r/#/c/241471/ who ask me to file a task.

Please remove your self if I should have not added you to this task.

Change 243719 had a related patch set uploaded (by Paladox):
Split module mediawiki.skinning.interface into three different modules

https://gerrit.wikimedia.org/r/243719

Jdlrobson triaged this task as Medium priority.Nov 30 2015, 7:47 PM
Jdlrobson added a subscriber: Jdlrobson.
Jdlrobson lowered the priority of this task from Medium to Lowest.Dec 14 2015, 10:13 PM

Change 243719 abandoned by Paladox:
Split module mediawiki.skinning.interface into two different modules

https://gerrit.wikimedia.org/r/243719

Change 546733 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] ResourceLoaderSkinModule is configurable with different features

https://gerrit.wikimedia.org/r/546733

Change 546733 merged by jenkins-bot:
[mediawiki/core@master] ResourceLoaderSkinModule: Provide optional mediawiki.skinning styles

https://gerrit.wikimedia.org/r/546733

Jdlrobson claimed this task.

This is now done. The mediawiki.skinning.interface module is now an instance of ResourceLoaderSkinModule::class - any extension or skin (although I heavily recommend the latter) is now able to define it's own module with the ResourceLoaderSkinModule class and pick and choose which "features" it wants to support.