Generalize OO.ui.GroupElement into an OO.EmitterList
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mooeypoo
	Oct 5 2015, 8:29 PM

Description

The main behavior of GroupElement mixin is extremely useful as a basic object, namely the handling of items and aggregation of events. We could move that into an OO.List object in oojs and have the GroupElement mixin inherit and expand on it.

Details

Subject	Repo	Branch	Lines +/-
GroupElement: Transform to be an OO.EmitterList mixin	oojs/ui	master	+75 -133
Have GroupElement use OO.EmitterList	oojs/ui	master	+74 -165
EmitterList: Change insertItem from @private to @protected	oojs/core	master	+12 -1
Add EmitterList class	oojs/core	master	+602 -5

Customize query in gerrit

Event Timeline

Mooeypoo created this task.Oct 5 2015, 8:29 PM

Mooeypoo claimed this task.

Mooeypoo raised the priority of this task from to Needs Triage.

Mooeypoo updated the task description. (Show Details)

Mooeypoo added projects: OOjs core, OOUI.

Mooeypoo subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2015, 8:29 PM

Change 243068 had a related patch set uploaded (by Mooeypoo):
Add an OO.List object

https://gerrit.wikimedia.org/r/243068

gerritbot added a project: Patch-For-Review.Oct 5 2015, 8:30 PM

Mooeypoo renamed this task from Generalize OO.ui.GroupElement into an OO.List to Generalize OO.ui.GroupElement into an OO.EmitterList.Oct 5 2015, 9:54 PM

Mooeypoo set Security to None.

Change 243245 had a related patch set uploaded (by Mooeypoo):
[wip] Have GroupElement use OO.EmitterList

https://gerrit.wikimedia.org/r/243245

Change 243068 merged by jenkins-bot:
Add EmitterList class

https://gerrit.wikimedia.org/r/243068

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 10 2015, 11:49 PM

Jdforrester-WMF triaged this task as Medium priority.Nov 17 2015, 1:36 AM

Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.

Change 300689 had a related patch set uploaded (by Mooeypoo):
Change EmitterList#insertItem from @private to @protected

https://gerrit.wikimedia.org/r/300689

Change 300689 merged by jenkins-bot:
EmitterList: Change insertItem from @private to @protected

https://gerrit.wikimedia.org/r/300689

Jdforrester-WMF closed this task as Resolved.Aug 23 2016, 8:41 PM

Jdforrester-WMF moved this task from Doing to OOjs-UI-0.17.9 on the OOUI board.

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.9); removed OOUI.

Change 243245 merged by jenkins-bot:
Have GroupElement use OO.EmitterList

https://gerrit.wikimedia.org/r/243245

Jdforrester-WMF reopened this task as Open.Aug 23 2016, 10:23 PM

Jdforrester-WMF moved this task from OOjs-UI-0.17.9 to Next-up on the OOUI board.Aug 23 2016, 11:59 PM

Jdforrester-WMF edited projects, added OOUI; removed OOUI (OOjs-UI-0.17.9).

Change 306307 had a related patch set uploaded (by Jforrester):
Have GroupElement use OO.EmitterList

https://gerrit.wikimedia.org/r/306307

Volker_E moved this task from Next-up to Reviewing on the OOUI board.Nov 17 2016, 10:40 PM

Krinkle moved this task from Inbox to Done on the OOjs core board.Mar 8 2017, 7:39 PM

Change 306307 merged by jenkins-bot:
[oojs/ui@master] GroupElement: Transform to be an OO.EmitterList mixin

https://gerrit.wikimedia.org/r/306307

Volker_E closed this task as Resolved.Mar 30 2017, 11:10 PM

Volker_E moved this task from Reviewing to OOjs-UI-0.20.1 on the OOUI board.

Volker_E edited projects, added OOUI (OOjs-UI-0.20.1); removed OOUI.

Volker_E removed a project: Patch-For-Review.

Volker_E removed a subscriber: gerritbot.

Krinkle moved this task from Done to Accepted Enhancement on the OOjs core board.Aug 14 2020, 1:47 PM

Generalize OO.ui.GroupElement into an OO.EmitterListClosed, ResolvedPublicActions

Description

Details

Event Timeline

Generalize OO.ui.GroupElement into an OO.EmitterList
Closed, ResolvedPublic
Actions