Page MenuHomePhabricator
Create Task
Maniphest T114725

mediawiki-config needs better test coverage
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/#/c/243728/ was able to take the site down because while it was a valid PHP, a typo in function name resulted in a fatal. We need to cover more of config with tests that actually execute the PHP files.

https://wikitech.wikimedia.org/wiki/Incident_documentation/20151005-MediaWiki

Related Objects

Event Timeline

MaxSem created this task.Oct 5 2015, 11:52 PM
MaxSem raised the priority of this task from to High.
MaxSem updated the task description. (Show Details)
MaxSem added projects: MediaWiki-General, Continuous-Integration-Infrastructure.
MaxSem added subscribers: MaxSem, greg.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2015, 11:52 PM
greg edited projects, added MediaWiki-Core-Tests; removed Continuous-Integration-Infrastructure.Oct 5 2015, 11:54 PM
greg set Security to None.
MaxSem renamed this task from mediawiki-config needs better coverage to mediawiki-config needs better test coverage.Oct 5 2015, 11:56 PM
• MZMcBride subscribed.Oct 5 2015, 11:59 PM
Krenair subscribed.Oct 6 2015, 3:38 PM
EBernhardson subscribed.EditedOct 6 2015, 4:24 PM

While not directly targeted at this, the new unit tests in https://gerrit.wikimedia.org/r/240615 will catch this specific problem by virtue of including InitialiseSettings.php

Jdlrobson awarded a token.Oct 6 2015, 4:47 PM
JanZerebecki subscribed.Oct 6 2015, 6:36 PM
Krinkle removed a project: MediaWiki-Core-Tests.Jul 7 2017, 5:12 AM
Krinkle edited projects, added Sustainability (Incident Followup), Wikimedia-Site-requests; removed MediaWiki-General.Sep 28 2021, 8:48 PM
Krinkle updated the task description. (Show Details)
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptSep 28 2021, 8:48 PM
Krinkle closed this task as Resolved.Sep 28 2021, 8:49 PM
Krinkle claimed this task.
Krinkle subscribed.

Also addressed by T121597: Implement MediaWiki pre-promote checks, which now runs prior to hitting production traffic.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL