Page MenuHomePhabricator

Use TitleInputWidget in the Score inspector for choosing overriding files
Open, LowestPublic1 Story Points

Description

Use the widget if choosing files for the override_midi or override_vorbis options.

Should be pretty straightforward. Example code can be found in MWInternalLinkAnnotationWidget. You'll want to set the namespace config option to mw.config.get( 'wgNamespaceIds' ).file too.

Event Timeline

Esanders created this task.Oct 6 2015, 7:26 PM
Esanders assigned this task to Tchanders.
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a subscriber: Esanders.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 6 2015, 7:26 PM
Jdforrester-WMF triaged this task as Normal priority.Oct 6 2015, 7:27 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

This is probably only useful if it restricts the results to the correct file types. This functionality currently doesn't exist in TitleInputWidget, but it could be added or a new class that does this could be made (e.g. FileInputWidget).

AlexMonk-WMF edited subscribers, added: AlexMonk-WMF; removed: Krenair.Feb 23 2016, 3:35 AM
Jdforrester-WMF removed Tchanders as the assignee of this task.Aug 23 2016, 6:09 PM
Jdforrester-WMF added a subscriber: Tchanders.

And also, in most production cases, this is more complex than you might expect. A title search will only search the local wiki for file description pages, it won't account for foreign file repositories (e.g. commons). Those count as known titles on local (e.g. non-commons) wikis, but they don't count as existing (see T72123 which has a core blocker).
I think it also wouldn't pick up cases where a file exists with no description page.

Seeing as TitleInputWidget would restrict inputs to only ones it recognises, I think we need to do it properly (like the media search dialog).

@Jdforrester-WMF, this is not strictly blocked by that, we handle the problem in the media dialog for files by searching each configured file repository.

Ebe123 renamed this task from Use TitleInputWidget in the Score inspector for choosing filenames to Use TitleInputWidget in the Score inspector for choosing overriding files.Dec 8 2017, 1:10 AM
Ebe123 updated the task description. (Show Details)
Ebe123 added a subscriber: Ebe123.

Took me a little while to understand the request. Updating description and title.

Deskana lowered the priority of this task from Normal to Lowest.Aug 30 2018, 12:22 PM