Page MenuHomePhabricator

RevisionList component should use i18n strings instead of hardcoded text for column headers
Closed, ResolvedPublic

Description

The React component RevisionList had hard-coded labels for Class, Title, Edited By, etc. : https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/app/assets/javascripts/components/revisions/revision_list.cjsx

Instead, it should use the I18n javascript to utilize translated strings, like the StudentList component does: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/app/assets/javascripts/components/students/student_list.cjsx

Event Timeline

Ragesoss created this task.Oct 7 2015, 5:01 PM
Ragesoss raised the priority of this task from to Needs Triage.
Ragesoss updated the task description. (Show Details)
Ragesoss moved this task to Microtasks on the Education-Program-Dashboard board.
Ragesoss added a subscriber: Ragesoss.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2015, 5:01 PM
awight set Security to None.
Kenua added a subscriber: Kenua.Oct 13 2015, 10:02 AM
Restricted Application added a subscriber: Base. · View Herald TranscriptOct 13 2015, 10:02 AM
Kenua added a comment.Oct 13 2015, 1:33 PM

Tell, please, what should I do if I want to take this microtask?

@Kenua The first (and bigger) step is to get a development environment set up for the Wiki Ed Dashboard. See the instructions here, and let me know if you run into any trouble: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/docs/setup.md

The next step is to basically take the same approach as in this commit to replace hardcoded strings with strings that come from the i18n locales: https://github.com/WikiEducationFoundation/WikiEduDashboard/commit/0bcea73aa6b1ee133076fd9b7246bfe3f8c93f34

Kenua added a comment.Oct 15 2015, 3:20 PM

Sorry for delay, I've spent a lot of time trying to adapt this instruction for Windows 7, nearly without any result. Is it feasibly at all? Especially I don't understand what to do with config files.

Hi @Kenua. Unfortunately, I don't have any experience with running a Windows 7 development environment. I think your best bet would be to set up a virtual machine with Ubuntu, using VirtualBox: https://www.virtualbox.org/wiki/Downloads

After that, the setup instructions should work within the virtual machine.

Kenua added a comment.Oct 30 2015, 2:42 PM
This comment was removed by Kenua.
Haritha28 claimed this task.Nov 5 2015, 1:32 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 5 2015, 1:32 PM