Page MenuHomePhabricator

Formatting of footer in Echo notification drop-downs is messed up in Firefox
Closed, ResolvedPublic

Description

The footer in the new Echo notification drop-down has a few problems:

  1. The labels of the buttons are skewed way over to the right rather than being centered or left-justified.
  2. The dividing line between them doesn't go all the way to the bottom.
  3. The text doesn't line up vertically with the icons.

Screen Shot 2015-10-08 at 2.40.25 PM.png (102×470 px, 16 KB)

Event Timeline

kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added a project: Notifications.
kaldari added a subscriber: kaldari.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 243376 had a related patch set uploaded (by Catrope):
NotificationBadgeWidget: Fix alignment of actions buttons

https://gerrit.wikimedia.org/r/243376

Turns out it does. That patch solves #1 (centers the labels). #2 and #3 are not fixed by that patch, and appear to be specific to Firefox.

Catrope renamed this task from Formatting of footer in Echo notification drop-downs is messed up to Formatting of footer in Echo notification drop-downs is messed up in Firefox.Oct 8 2015, 9:30 PM
Catrope set Security to None.

Change 243376 merged by jenkins-bot:
NotificationBadgeWidget: Fix alignment of actions buttons

https://gerrit.wikimedia.org/r/243376

Problem #2 and #3 is in Safari as well. See All Notification

Screen Shot 2015-10-12 at 8.18.57 PM.png (424×928 px, 30 KB)

Catrope claimed this task.

AFAICT this is fixed now