Formatting of footer in Echo notification drop-downs is messed up in Firefox
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kaldari
	Oct 8 2015, 8:45 PM

Description

The footer in the new Echo notification drop-down has a few problems:

The labels of the buttons are skewed way over to the right rather than being centered or left-justified.
The dividing line between them doesn't go all the way to the bottom.
The text doesn't line up vertically with the icons.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	NotificationBadgeWidget: Fix alignment of actions buttons	mediawiki/extensions/Echo	master	+5 -0

Customize query in gerrit

Event Timeline

kaldari created this task.Oct 8 2015, 8:45 PM

kaldari raised the priority of this task from to Needs Triage.

kaldari updated the task description. (Show Details)

kaldari added a project: Notifications (Echo).

kaldari subscribed.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 8 2015, 8:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Luke081515 awarded a token.Oct 8 2015, 8:57 PM

Luke081515 subscribed.

Perhaps https://gerrit.wikimedia.org/r/#/c/243376/ fixes this?

Change 243376 had a related patch set uploaded (by Catrope):
NotificationBadgeWidget: Fix alignment of actions buttons

https://gerrit.wikimedia.org/r/243376

gerritbot added a project: Patch-For-Review.Oct 8 2015, 9:15 PM

Turns out it does. That patch solves #1 (centers the labels). #2 and #3 are not fixed by that patch, and appear to be specific to Firefox.

Catrope renamed this task from Formatting of footer in Echo notification drop-downs is messed up to Formatting of footer in Echo notification drop-downs is messed up in Firefox.Oct 8 2015, 9:30 PM

Catrope added a project: Browser-Support-Firefox.

Catrope set Security to None.

Change 243376 merged by jenkins-bot:
NotificationBadgeWidget: Fix alignment of actions buttons

https://gerrit.wikimedia.org/r/243376

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)).Oct 8 2015, 10:00 PM

Problem #2 and #3 is in Safari as well. See All Notification

Screen Shot 2015-10-12 at 8.18.57 PM.png (424×928 px, 30 KB)

AFAICT this is fixed now

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptFeb 13 2016, 12:23 AM

	F2714450: Screen Shot 2015-10-12 at 8.18.57 PM.png
	Oct 13 2015, 12:19 AM

	F2667091: Screen Shot 2015-10-08 at 2.40.25 PM.png
	Oct 8 2015, 8:45 PM

Formatting of footer in Echo notification drop-downs is messed up in FirefoxClosed, ResolvedPublicActions

Description

Details

Event Timeline

Formatting of footer in Echo notification drop-downs is messed up in Firefox
Closed, ResolvedPublic
Actions