Page MenuHomePhabricator
Create Task
Maniphest T115056

Media upload dialog reports that file page exists, but not the file, even if the file does exist
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Media upload dialog reports that file page exists, but not the file, even if the file does exist (using filepageexists message). I think that's the wrong one to use.

Screen Shot 2015-10-06 at 2.42.52 PM.png (127×415 px, 23 KB)

Also, the link points to a page named "Foo.png" and not "File:Foo.png".

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+9 -2mw.Upload.BookletLayout: Use appropriate messages for warnings
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Oct 8 2015, 9:07 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added projects: VisualEditor, Multimedia.
matmarex added subscribers: matmarex, • Prtksxna.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptOct 8 2015, 9:07 PM
• Prtksxna added a comment.Oct 9 2015, 8:11 AM

Should we use a different message here?

See also T114130#1706673

matmarex added a comment.Oct 9 2015, 10:11 AM

I think so.

matmarex merged a task: T114950: Consider changing the error message that shows up while trying to upload an already uploaded image.Oct 9 2015, 11:38 AM
matmarex added a subscriber: Ryasmeen.
matmarex triaged this task as Medium priority.Oct 9 2015, 11:43 AM
matmarex set Security to None.
Jdforrester-WMF added a project: VisualEditor-MediaWiki-Media.Oct 10 2015, 2:40 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
matmarex assigned this task to • Prtksxna.Oct 12 2015, 3:33 PM
gerritbot added a subscriber: gerritbot.Oct 12 2015, 6:40 PM

Change 245497 had a related patch set uploaded (by Bartosz Dziewoński):
mw.Upload.BookletLayout: Use appropriate messages for warnings

https://gerrit.wikimedia.org/r/245497

gerritbot added a project: Patch-For-Review.Oct 12 2015, 6:40 PM
gerritbot added a comment.Oct 12 2015, 7:59 PM

Change 245497 merged by jenkins-bot:
mw.Upload.BookletLayout: Use appropriate messages for warnings

https://gerrit.wikimedia.org/r/245497

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)), MW-1.27-release-notes.Oct 12 2015, 8:00 PM
Jdforrester-WMF closed this task as Resolved.Oct 12 2015, 8:06 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.
• Prtksxna added a comment.Oct 13 2015, 3:39 AM

We still need to change the messages and the links, but this makes things right-er.

matmarex added a comment.Oct 13 2015, 12:36 PM

My patches 3cfcce3e2b47597382306b4d083bf361b35b1112 and ffd100df378f76efeb054e1b103029a86414a931 also tweaked the messaging here.

matmarex edited projects, added MW-1.26-release; removed MW-1.27-release-notes.Oct 16 2015, 6:42 PM

Patches cherry-picked to REL1_26 in 03e6ac38bf51456d9035b58040422358c41939f7.

matmarex added a project: MediaWiki-Uploading.Sep 21 2016, 5:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL