Page MenuHomePhabricator
Create Task
Maniphest T115102

Rename scrubWikitext parameter with scrub_wikitext in ContentTranslation code
Closed, ResolvedPublic
Actions

Description

CX Publish api uses scrubWikitext - it need renaming as per T114620

Details

SubjectRepoBranchLines +/-
Send both scrubWikitext and scrub_wikitextmediawiki/extensions/ContentTranslationmaster+1 -0
Rename scrubWikitext to scrub_wikitextmediawiki/extensions/ContentTranslationmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• santhosh created this task.Oct 9 2015, 10:08 AM
• santhosh raised the priority of this task from to Needs Triage.
• santhosh updated the task description. (Show Details)
• santhosh added projects: ContentTranslation, ContentTranslation-Release7, LE-CX7-Sprint 1, good first task.
• santhosh subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2015, 10:08 AM
Pginer-WMF moved this task from Backlog to Infrastructure WMF requirements on the ContentTranslation-Release7 board.Oct 9 2015, 10:29 AM
Ricordisamoa subscribed.Oct 9 2015, 1:04 PM
Amire80 triaged this task as Medium priority.Oct 9 2015, 6:03 PM
Amire80 set Security to None.
Amire80 moved this task from Needs Triage to CX7 on the ContentTranslation board.
Devirk subscribed.Oct 10 2015, 8:46 AM
• santhosh claimed this task.Oct 12 2015, 3:37 AM
gerritbot subscribed.Oct 12 2015, 4:10 AM

Change 245203 had a related patch set uploaded (by Santhosh):
Rename scrubWikitext to scrub_wikitext

https://gerrit.wikimedia.org/r/245203

gerritbot added a project: Patch-For-Review.Oct 12 2015, 4:10 AM
• santhosh moved this task from Backlog to In review on the LE-CX7-Sprint 1 board.Oct 12 2015, 4:15 AM
gerritbot added a comment.Oct 12 2015, 4:29 AM

Change 245203 merged by jenkins-bot:
Rename scrubWikitext to scrub_wikitext

https://gerrit.wikimedia.org/r/245203

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)).Oct 12 2015, 5:00 AM
Nikerabbit moved this task from In review to QA on the LE-CX7-Sprint 1 board.Oct 12 2015, 7:05 AM
KartikMistry moved this task from QA to Done on the LE-CX7-Sprint 1 board.Oct 15 2015, 5:41 AM
Amire80 added projects: Essential-Work, Technical-Debt.Oct 15 2015, 12:24 PM
Amire80 subscribed.

Does it need verification in production, or can it be closed?

Amire80 closed this task as Resolved.Oct 21 2015, 6:14 AM
Ricordisamoa removed a project: Patch-For-Review.Oct 21 2015, 6:35 AM
Amire80 edited a custom field.Oct 24 2015, 12:46 PM
Amire80 mentioned this in T117399: "[[New York ]]<nowiki/>population" appears instead of "[[New York]] population" in translations.Nov 12 2015, 7:48 AM
Amire80 reopened this task as Open.Nov 12 2015, 8:12 AM

Reopening. I suspect that something is wrong here. See T117399.

gerritbot added a comment.Nov 12 2015, 11:22 AM

Change 252665 had a related patch set uploaded (by Amire80):
Send both scrubWikitext and scrub_wikitext

https://gerrit.wikimedia.org/r/252665

gerritbot added a project: Patch-For-Review.Nov 12 2015, 11:22 AM
Amire80 renamed this task from Rename scrubWikitext parameter with scrub_wikitext to Rename scrubWikitext parameter with scrub_wikitext in ContentTranslation code.Nov 12 2015, 11:25 AM
Amire80 added a parent task: T114620: Deprecate scrubWikitext in favour of scrub_wikitext.
Amire80 removed a project: LE-CX7-Sprint 1.
gerritbot added a comment.Nov 12 2015, 12:39 PM

Change 252665 abandoned by Amire80:
Send both scrubWikitext and scrub_wikitext

https://gerrit.wikimedia.org/r/252665

Devirk edited a custom field.Nov 21 2015, 2:49 PM
Devirk unsubscribed.
Danny_B moved this task from Unsorted to Needs refactor on the Technical-Debt board.Jan 23 2016, 12:35 AM
Amire80 moved this task from CX7 to CX8 on the ContentTranslation board.Jan 24 2016, 10:26 PM
Amire80 added a comment.Feb 14 2016, 3:38 PM

Is this done now?

Amire80 moved this task from CX8 to CX7 on the ContentTranslation board.Feb 14 2016, 3:39 PM
• santhosh closed this task as Resolved.Feb 15 2016, 12:01 PM

Yes, this is done long time back

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL