Page MenuHomePhabricator

On Flow activation, do not create an archive page when the page exists but is empty
Closed, InvalidPublic


On zh.wp, User:小躍 requested to have Flow on a subpage.

I've created User_talk:小躍/Flow and Special:EnableFlow created User_talk:小躍/Flow/存档_1 (deleted since)

Event Timeline

Trizek-WMF raised the priority of this task from to Needs Triage.
Trizek-WMF updated the task description. (Show Details)
Trizek-WMF added a subscriber: Trizek-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF renamed this task from On Flow activation, do not create an archive page when the page is empty to On Flow activation, do not create an archive page when the page exists but is empty.Oct 9 2015, 2:30 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

You can't create an 'empty' page (but you can blank an existing page), so this would mean deleting content with no way of retrieving it, right? This seems like a bad idea.

I may have not express very well So I think we don't understand each other: iirc the page User_talk:小躍/Flow didn't exist when I've created the Flow board on it. User_talk:小躍/Flow/存档_1 has been created automatically, but was not relevant.

Counterexample on this page: the subpage was not created, and then no archive page has been created.
I'm lost. :)

This needs clear reproducible steps. The description makes it sound like you created as a normal page before running EnableFlow.

If the page exists before EnableFlow is run, it needs to go somewhere. We can't just delete it, because it could have old revisions, and we don't want diffs and history of that page to break.

(Checking whether it only has a single empty revision seems like an overkill special case to me, and even then there's no reason to break the oldid for that revision.)

I am the one who suggested this to Trizek. I think what I meant has already achieved. And User:小躍 is a really special case here.

And if anyone are interested in the details: User:小躍 has created the page User_talk:小躍/Flow (with no content) before requesting for Flow activated on User_talk:小躍/Flow, and the EnableFlow tool moved that empty page, but it was meaningless so it is deleted after user request. So I was thinking if a check for meaningless history (e.g. that user created an empty page) or empty history (i.e. non-existing page) would be meaningful. Now I know it won't move anything if the page requested had not existed before activation and I agree that the check would be an overkill.

I guess this could be closed unless Trizek has anything to add.

Thank you again Trizek for the advocation and others for your valuable opinions. I'm sorry if there are any misunderstanding. :)

Mattflaschen-WMF claimed this task.

No problem. Thanks for clarifying.