Page MenuHomePhabricator

Minerva and desktop skins use inconsistent HTML
Closed, ResolvedPublic

Description

The Vector skin wraps all user generated content in an element with id #mw-content-text
Let's also do this in Minerva so the two skins are more in line with each other.

This is a potential breaking change for those JavaScript modules who are not using the Page or Skin JavaScript classes so consider those and backwards compatibility when merging.

As we move forward and start to work on features that work on both desktop and mobile and do more in JS we want to minimise these inconsistencies.

When doing this, we should be sure to ensure that we do not break T113651

Event Timeline

Jdlrobson updated the task description. (Show Details)
Jdlrobson raised the priority of this task from to Normal.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2015, 8:49 PM
Jdlrobson updated the task description. (Show Details)Oct 9 2015, 8:50 PM
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)

Change 243227 had a related patch set uploaded (by Jdlrobson):
Hygiene: Move logic for section wrapping out of skin into hook

https://gerrit.wikimedia.org/r/243227

Jdlrobson changed the task status from Open to Stalled.Oct 29 2015, 9:01 PM
Jdlrobson added subscribers: bmansurov, phuedx, jhobs.

Guess we should probably talk about this. @bmansurov, @phuedx @jhobs - do we agree we should make the html of minerva more closely aligned to Vector?

Guess we should probably talk about this. @bmansurov, @phuedx @jhobs - do we agree we should make the html of minerva more closely aligned to Vector?

I'm definitely down for that. The fewer differences in HTML the better imo.

Yes, I agree.

phuedx added a comment.Nov 2 2015, 5:43 AM

Agreed. If we felt strongly enough that $wikitext should be rendered in a certain way, then we should discuss it with the wider community and upstream the changes. Otherwise, we should aim for parity.

Okay so the impact of this is we are making a breaking change. The only thing I'm aware of this breaking is QuickSurveys so we should make this change ASAP given we want to run a survey next week... or delay this until at least the first survey has been run.

Jdlrobson moved this task from Backlog to Tasks on the MobileFrontend board.Nov 4 2015, 4:47 PM

Change 243227 merged by jenkins-bot:
Breaking change: Move logic for section wrapping out of skin into hook

https://gerrit.wikimedia.org/r/243227