Page MenuHomePhabricator

[AOI][Citation bot] `|display-authors=9` no longer necessary for exactly nine authors
Closed, ResolvedPublic


From :


  • new bug

Reported by

  • – Jonesey95 (talk) 01:32, 22 March 2015 (UTC)

Type of bug

  • Improvement

Actual / expected output

  • The bot adds |display-authors=9 when there are exactly nine authors.
  • The bot should not add |display-authors=9 when there are exactly nine authors.

Requested action from maintainer

  • Remove code that adds |display-authors=9 when there are exactly nine authors. See Category:CS1 maint: display-authors


  • The bot is still inserting this parameter (see the Hongying citation), but it is not necessary. Fhocutt (WMF), can you disable this portion of the code? – Jonesey95 (talk) 03:29, 22 September 2015 (UTC)

Tentative story points: 2. Unless this is special-cased somewhere weird, this probably happens in Template::add_if_new().

Event Timeline

Fhocutt raised the priority of this task from to Low.
Fhocutt updated the task description. (Show Details)
Fhocutt added a project: Community-Tech.
Fhocutt added subscribers: Fhocutt, Aklapper.

This looks easy, but code comments make me wonder whether this is a good change to be making. The code to insert display-authors=9 is a special case, inserted so that "et al. " would not hide only one author (from code comments: "Better display an author's name than 'et al' when the et al only hides 1 author!"). I am not sure whether the reasoning that led to this special case is still valid. Commented here to ask:

Answer from Jonesey95:

The CS1 citation module (and its predecessor code) that renders {{cite journal}} and similar templates used to display "et al." when exactly nine authors were listed, for reasons too boring to go into. The module no longer does that; it displays all authors unless |display-authors=x is used (where x is a number less than the number of authors in the cite template). So |display-authors=9 is redundant when there are exactly nine authors listed.

I've updated the CS1 module on testwiki to incorporate these changes.

Merged and pulled onto Tool Labs.

kaldari renamed this task from [Citation bot] `|display-authors=9` no longer necessary for exactly nine authors to [AOI][Citation bot] `|display-authors=9` no longer necessary for exactly nine authors.Oct 24 2015, 2:09 AM