Page MenuHomePhabricator
Create Task
Maniphest T115181

Can't use the undo action (Ctrl-Z, etc.) after the application of a link in ContentTranslation
Closed, ResolvedPublic
Actions

Description

It's impossible to use the undo action (Ctrl-Z, etc.) after the application of a link in ContentTranslation.

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedPginer-WMFT115181 Can't use the undo action (Ctrl-Z, etc.) after the application of a link in ContentTranslation
 ResolvedNoneT105447 [Epic] replace plain contenteditable with VisualEditor in ContentTranslation
 ResolvedAmire80T149162 Complete the MVP document for CX and VE integration
 InvalidNoneT150652 Content Translation feature parity checklist post VisualEditor integration
 ResolvedPginer-WMFT166578 Design review for CX2
 DeclinedNoneT168252 Misaligned icon and unnecessary warning on new translation input field
 Resolved• Petar.petkovicT168257 Translation controls become sticky too early overlapping with the personal toolbar
 Resolved• Petar.petkovicT168259 Link to view page is misplaced in the translation editor
 Resolved• Petar.petkovicT168267 Card title text has very low contrast
 ResolvedPginer-WMFT168275 Automatic translation card showing unnecessary options initially
 OpenNoneT168280 Adjust spacing for cards
 Resolved• Petar.petkovicT168283 Drop-down and its menu are misaligned in the automatic translation card
 Resolved• Petar.petkovicT168285 Styling for "Add translation" invite
 Resolved• Petar.petkovicT168287 CX2: Warning about article having changed too much
 ResolvedPginer-WMFT168288 Paragraph alignment breaks when resizing the browser window
 Resolved• santhoshT168290 CX2: Adjust the design for link cards
 ResolveddchanT168221 ContentTranslation: integrate VisualEditor
 Resolved• santhoshT152586 Reorganize the CX classes using OOjs/OOUI (tracker)
 Resolved• santhoshT156911 [CX-OOJS] Syntax error, unrecognized expression: unsupported pseudo: 0_3-0
 ResolvedNikerabbitT162110 CX2: Machine translation service client
 OpenNoneT162112 CX2: Dictionary tool
Resolved• santhoshT162113 CX2: Infrastructure for section-level progress calculation
 ResolvedPginer-WMFT162114 CX2: Template adaptation
 OpenNoneT171547 [wmf.10] Display of Template:Div_col on Translation page needs improvement
ResolvedPginer-WMFT162126 CX2: Link adaptation
 InvalidNoneT162767 CX2: Content syncing between ui and models
 Resolved• Petar.petkovicT162768 CX2: Basic translation publishing and error handling
 Resolved• santhoshT163184 CX2: Translation units should be prepared for elements that exist in translation alone
 Resolved• santhoshT164067 CX2: Blocklevel translation units inside a section is not translatable

Event Timeline

Esanders created this task.Oct 10 2015, 1:13 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: ContentTranslation.
Esanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2015, 1:13 PM
Esanders added a subtask: T105447: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation.Oct 10 2015, 1:17 PM
Amire80 subscribed.EditedOct 10 2015, 2:04 PM

There's no description, so I'm not sure what does it mean.

If it means that a link in the translation cannot be converted to plain text, that it's wrong - there's a "Remove link" button in the sidebar when you click a link.

Amire80 removed a subtask: T105447: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation.Oct 13 2015, 6:36 AM

Please reopen if I am misunderstanding this.

Amire80 closed this task as Invalid.Oct 13 2015, 6:37 AM
Amire80 set Security to None.
Esanders reopened this task as Open.Oct 13 2015, 9:37 AM

Sorry, I mean automatic undo as in CTRL+Z. As you only have native undo from CE you will encounter its bugs, such as not being able to undo past a programmatic change to the DOM. VE has its own transactions and undo stack so we avoid this problem.

Esanders added a parent task: T105447: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation.Oct 13 2015, 9:39 AM
Amire80 renamed this task from Can't undo the application of a link to Can't use the undo action (Ctrl-Z, etc.) after the application of a link in ContentTranslation.Oct 13 2015, 9:50 AM
Amire80 updated the task description. (Show Details)
In T115181#1720882, @Esanders wrote:

Sorry, I mean automatic undo as in CTRL+Z. As you only have native undo from CE you will encounter its bugs, such as not being able to undo past a programmatic change to the DOM. VE has its own transactions and undo stack so we avoid this problem.

Oh, OK. Thanks for the explanation.

Amire80 added a project: Essential-Work.Oct 13 2015, 9:51 AM
Amire80 removed a parent task: T105447: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation.
Amire80 added a subtask: T105447: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation.
Amire80 triaged this task as Medium priority.Oct 15 2015, 12:22 PM
Amire80 moved this task from Needs Triage to Bugs on the ContentTranslation board.
Pginer-WMF closed this task as Resolved.Mar 16 2018, 10:17 AM
Pginer-WMF claimed this task.
Pginer-WMF subscribed.

This is already supported in CX2, the major refactoring and architectural update of Content Translation to integrate the same editing surface as VisualEditor. Currently it can be tested by adding &version=2 to the URL of the translation editor (still experimental), and will become the default version in the future.

nshahquinn closed subtask T105447: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation as Resolved.Sep 10 2019, 11:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL