Page MenuHomePhabricator
Create Task
Maniphest T115380

If the user Saves an upload, but does not then insert it, reset the form correctly
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Go to Insert>Media

2.Go to Upload
3.Select an image and click on upload
4.Fill up all the fields correctly in the Media Settings dialog, click on Save.
5.Now on the second Media Settings dialog instead of clicking on "use this image" click on Back which will take you back to the Media Search dialog
6.Now click on Upload tab

Observe it does not have same option to upload a picture but a different page with Usage and File Name showing

Screen Shot 2015-10-13 at 3.57.31 PM.png (548×513 px, 29 KB)

Details

SubjectRepoBranchLines +/-
ve.ui.MWMediaDialog: Reset upload booklet when done uploadingmediawiki/extensions/VisualEditormaster+5 -1
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Oct 13 2015, 7:57 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald TranscriptOct 13 2015, 7:57 PM
Jdforrester-WMF renamed this task from The Media Upload page has different fields inside after clicking on "Cancel" on uploading an image and going back to same upload page to If the user Saves an upload, but does not then insert it, reset the form correctly.Oct 20 2015, 7:26 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF added projects: Multimedia, VisualEditor-MediaWiki-Media.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF added a subscriber: • Prtksxna.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptOct 20 2015, 7:26 PM
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.Oct 20 2015, 7:26 PM
matmarex claimed this task.Oct 22 2015, 6:23 PM
gerritbot subscribed.Oct 22 2015, 6:33 PM

Change 248090 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ui.MWMediaDialog: Reset upload booklet when done uploading

https://gerrit.wikimedia.org/r/248090

gerritbot added a project: Patch-For-Review.Oct 22 2015, 6:33 PM
Jdforrester-WMF closed this task as Resolved.Oct 22 2015, 6:44 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Oct 22 2015, 6:47 PM

Change 248090 merged by jenkins-bot:
ve.ui.MWMediaDialog: Reset upload booklet when done uploading

https://gerrit.wikimedia.org/r/248090

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 22 2015, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL