MediaWiki 1.26 bundled repo should be state of the art
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Oct 13 2015, 8:32 PM

Description

All the extensions and skins to be bundled in 1.26.0 should represent the state of the art.

Using the list of extensions ./make-release.py --list-bundled 1.26.0 I crafted a very lame script pasted at P2189 which generates as of Nov 23rd:

Repo	Registration	composer test	npm test
extensions/Cite	ok	ok	ok
extensions/CiteThisPage	ok	ok	ok
extensions/ConfirmEdit	ok	ok	ok
extensions/Gadgets	ok	ok	ok
extensions/ImageMap	ok	no test	ok
extensions/InputBox	ok	ok	ok
extensions/Interwiki	ok	ok	ok
extensions/LocalisationUpdate	ok	ok	ok
extensions/Nuke	ok	ok	ok
extensions/ParserFunctions	ok	ok	ok
extensions/PdfHandler	ok	ok	ok
extensions/Poem	ok	ok	ok
extensions/Renameuser	ok	ok	ok
extensions/SpamBlacklist	ok	ok	ok
extensions/SyntaxHighlight_GeSHi	ok	ok	ok
extensions/TitleBlacklist	ok	ok	ok
extensions/WikiEditor	ok	ok	ok
skins/CologneBlue	ok	ok	ok
skins/Modern	ok	ok	ok
skins/MonoBook	ok	ok	ok
skins/Vector	ok	ok	ok

We have a lot of activity going on to add composer.json / npm.json with a test entry point. So most probably the master branches have something.

In most case we will have to drop jshint/phpcs though, but maybe we can just bump the REL1_26 branch to latest master to catch up.

Details

	Subject	Repo	Branch	Lines +/-
	build: Add composer test, initially with just parallel-test	mediawiki/extensions/Flow	REL1_26	+19 -14
	Add some Jenkins tests	mediawiki/extensions/ConfirmEdit	REL1_26	+69 -13

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	hashar	T115392 MediaWiki 1.26 bundled repo should be state of the art
Resolved	Legoktm	T94758 Convert all skins and extensions bundled with the tarball to use extension registration
Resolved	Jdforrester-WMF	T87893 Convert Cite to use extension registration
Resolved	Paladox	T88047 Convert ConfirmEdit extension to use extension registration
Resolved	Paladox	T87918 Convert Gadgets to use extension registration
Resolved	Jdforrester-WMF	T87929 Convert ImageMap to use extension registration
Resolved	Legoktm	T97921 Add support for $wgParserTestFiles to ExtensionProcessor
Resolved	Florian	T87931 Convert InputBox to use extension registration
Resolved	Jdforrester-WMF	T88052 Convert Interwiki extension to use extension registration
Resolved	Paladox	T87937 Convert LocalisationUpdate to use extension registration
Resolved	None	T87946 Convert Nuke to use extension registration
Resolved	Legoktm	T87955 Convert ParserFunctions to use extension registration
Resolved	Legoktm	T87957 Convert PdfHandler to use extension registration
Resolved	Legoktm	T97908 Add support for $wgMediaHandlers in extension registration
Resolved	Legoktm	T87959 Convert Poem to use extension registration
Resolved	Legoktm	T87967 Convert Renameuser to use extension registration
Resolved	Paladox	T88059 Convert SpamBlacklist extension to use extension registration
Resolved	Legoktm	T88063 Convert SyntaxHighlight_GeSHi extension to use extension registration
Resolved	Krenair	T87982 Convert TitleBlacklist to use extension registration
Resolved	Legoktm	T87993 Convert WikiEditor to use extension registration

Event Timeline

hashar created this task.Oct 13 2015, 8:32 PM

hashar raised the priority of this task from to Needs Triage.

hashar updated the task description. (Show Details)

hashar added projects: MW-1.26-release, Continuous-Integration-Config.

hashar added subscribers: hashar, • demon, Legoktm, Paladox.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2015, 8:32 PM

That follow up Release-Engineering-Team weekly meeting from today.

Change 246208 had a related patch set uploaded (by Paladox):
Add some Jenkins tests

https://gerrit.wikimedia.org/r/246208

gerritbot added a project: Patch-For-Review.Oct 14 2015, 12:30 PM

Paladox updated the task description. (Show Details)Oct 14 2015, 12:33 PM

Paladox set Security to None.

Paladox updated the task description. (Show Details)

@Paladox that is for REL1_26. We will need to do some backports.

Just realised sorry.

Change 246208 merged by jenkins-bot:
Add some Jenkins tests

https://gerrit.wikimedia.org/r/246208

Change 246981 had a related patch set uploaded (by Paladox):
build: Add composer test, initially with just parallel-test

https://gerrit.wikimedia.org/r/246981

Change 246991 had a related patch set uploaded (by Paladox):
Add composer.json

https://gerrit.wikimedia.org/r/246991

• demon triaged this task as Medium priority.Oct 22 2015, 4:44 PM

• demon moved this task from Backlog to To be fixed on the MW-1.26-release board.Nov 2 2015, 7:18 PM

Refreshed table. ConfirmEdit got composer/npm added.

I don't think we'll get composer.json created & merged w/ tests and backported to REL1_26 by Wednesday. Suggest just trying to finish getting ConfirmEdit's registration backported and npm for everything (which is done I think).

hashar updated the task description. (Show Details)Nov 23 2015, 9:27 PM

I have added a bunch of composer entry points. Some are falling such as LocalizationUpdate https://gerrit.wikimedia.org/r/#/c/254927/ :(

ConfirmEdit registration was added via T88047

https://gerrit.wikimedia.org/r/#/c/250277/ is the backport for REL1_26.

We will probably want to look at REL1_26..master because some changes have been made to extension.json/skin.json since we have cut the branches.

For some repos, I just went ahead and did a merge commit of master into REL1_26.

hashar updated the task description. (Show Details)Nov 24 2015, 10:24 AM

• demon added a subtask: T94758: Convert all skins and extensions bundled with the tarball to use extension registration.Nov 24 2015, 6:37 PM

For ImageMap I could not add a composer test entry point because the PHP entry point check for wfLoadExtension existence and dies. When running php-parallel-lint that causes the job to fail.

@polybuildr had the same issue and claimed T103800 . There is probably a solution there.

From all REL1_26 bundled repos, only ImageMap and LocalisationUpdate have a composer.json file containing an autoload section.

@polybuildr state that removing is the easiest way since the RfC for extension management using composer was declined..

We might want to review all the registration files to be sure.

As per the discussion at T103800, since T467: RfC: Extension management with Composer was declined, the easiest way is to not autoload anything via composer.

Another approach I had explored was checking if the script is executing in the CLI and if so, don't die. But as @Legoktm explained to me then, that could silently break something in the future and then we'd be very confused.

Legoktm updated the task description. (Show Details)Nov 25 2015, 4:14 PM

Legoktm closed subtask T94758: Convert all skins and extensions bundled with the tarball to use extension registration as Resolved.

ImageMap's composer.json is incompatible with running "composer test". We can fix that by making a breaking change to remove the autoload in composer (which we've done in ULS, ContentTranslation, Vector, etc.), but it's probably not worth it just to add phplint. Marking as resolved since everything else is done.

Legoktm reassigned this task from Legoktm to hashar.Nov 25 2015, 4:25 PM

Agreed with @Legoktm ;-)

• demon moved this task from To be fixed to Done on the MW-1.26-release board.Nov 25 2015, 4:26 PM

Change 246981 merged by jenkins-bot:
build: Add composer test, initially with just parallel-test