Page MenuHomePhabricator
Create Task
Maniphest T115395

Improve Parsoid's mock API, test the batch API client
Open, MediumPublic
Actions

Description

Currently, parserTests.js runs with usePHPPreProcessor=false, so the preprocessor expansion client is untested. Also, the batch API client (Batcher, BatchRequest) is not tested. It would be good to run parserTests.js with usePHPPreProcessor=true and batch API enabled, and to expand the mock API as necessary to make this work.

Details

SubjectRepoBranchLines +/-
[WIP] Get rid of native template expansionmediawiki/services/parsoidmaster+563 -1 K
Customize query in gerrit

Related Objects

Event Timeline

• tstarling created this task.Oct 13 2015, 8:47 PM
• tstarling raised the priority of this task from to Needs Triage.
• tstarling updated the task description. (Show Details)
• tstarling added a project: Parsoid.
• tstarling added subscribers: • tstarling, ssastry, cscott, Arlolra.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2015, 8:47 PM
• tstarling updated the task description. (Show Details)Oct 13 2015, 8:48 PM
• tstarling set Security to None.
ssastry mentioned this in T115461: Testing: Verify mock API responses against mediawiki API responses.Oct 14 2015, 12:53 PM
Arlolra claimed this task.Oct 16 2015, 3:45 PM
Arlolra triaged this task as Medium priority.
Arlolra added a project: Parsoid-Tests.Oct 16 2015, 3:49 PM
Arlolra removed Arlolra as the assignee of this task.Dec 21 2016, 1:21 AM
cscott mentioned this in T164384: Parsoid does not handle SOL correctly in native template expansion.May 3 2017, 3:45 PM
gerritbot subscribed.May 11 2017, 4:20 PM

Change 353325 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T115395: Mock the batch api

https://gerrit.wikimedia.org/r/353325

gerritbot added a project: Patch-For-Review.May 11 2017, 4:20 PM
gerritbot added a comment.May 11 2017, 8:22 PM

Change 353325 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T115395: Mock the batch api

https://gerrit.wikimedia.org/r/353325

Arlolra removed a project: Patch-For-Review.May 11 2017, 11:41 PM

Batching is mocked now, but parserTests isn't using it yet.

gerritbot added a comment.May 17 2017, 8:20 PM

Change 354151 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] Get rid of native template expansion

https://gerrit.wikimedia.org/r/354151

gerritbot added a project: Patch-For-Review.May 17 2017, 8:20 PM
gerritbot added a comment.May 19 2017, 6:14 PM

Change 354551 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T115395: Run parsertests with the batch api enabled

https://gerrit.wikimedia.org/r/354551

gerritbot added a comment.May 19 2017, 8:13 PM

Change 354551 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T115395: Run parsertests with the batch api enabled

https://gerrit.wikimedia.org/r/354551

Arlolra added a comment.May 19 2017, 8:15 PM

Parsertests now run with batching enabled. Just mocking the preprocessor left to go.

gerritbot added a comment.Aug 17 2017, 10:21 PM

Change 354151 abandoned by Arlolra:
[WIP] Get rid of native template expansion

Reason:
Will pick this up later ...

https://gerrit.wikimedia.org/r/354151

Arlolra removed a project: Patch-For-Review.Dec 11 2017, 11:02 PM
ssastry moved this task from Needs Triage to Testing on the Parsoid board.Dec 18 2017, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL