Page MenuHomePhabricator

Make labs salt use instance names than ids
Closed, ResolvedPublic

Description

Currently they use instance ids, which are horrible, horrible things.

Event Timeline

yuvipanda raised the priority of this task from to Needs Triage.
yuvipanda updated the task description. (Show Details)
yuvipanda added a project: acl*sre-team.
yuvipanda changed Security from none to None.
yuvipanda added a subscriber: yuvipanda.

Change 179592 had a related patch set uploaded (by Yuvipanda):
salt: Use fqdn as client id for labs as well

https://gerrit.wikimedia.org/r/179592

Patch-For-Review

So... talked to Ryan Lane some more and this is more complicated than expected ;)

Problem with fqdn is that deleting and creating an instance will cause complications because the salt (and puppet too, for that matter) certificates for the old instance won't be purged, so puppet/salt won't work.

Solution to this is to write a nova plugin that purges salt/puppet certs when an instance gets deleted.

fgiunchedi added a subscriber: fgiunchedi.

I have a draft of that plugin which I need to test.

Change 179592 abandoned by Yuvipanda:
salt: Use fqdn as client id for labs as well

Reason:
Issss uselessssss

https://gerrit.wikimedia.org/r/179592

@Andrew is this fixed with the switch to designate?

I've setup a salt environment today: The DNS seems to work fine with a minor tweak: In the pre-generated /etc/salt/minion there's a line starting with "id:" which sets the ec2id. If I remove these salt only uses the proper hostnames in salt-key.

Andrew claimed this task.