Page MenuHomePhabricator

All Civi hook code paths must be covered by PHPUnit tests
Closed, ResolvedPublic

Description

  • wmf_civicrm_civicrm_merge
  • wmf_civicrm_civicrm_post
  • wmf_civicrm_civicrm_contactListQuery
  • wmf_civicrm_civicrm_buildForm
  • wmf_civicrm_civicrm_validate

Event Timeline

awight created this task.Oct 13 2015, 11:44 PM
awight raised the priority of this task from to Normal.
awight updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2015, 11:44 PM
Eileenmcnaughton moved this task from Backlog to Doing on the Fundraising Sprint UB40 board.
Eileenmcnaughton set Security to None.

Change 246450 had a related patch set uploaded (by Eileen):
Remove custom quicksearch hook

https://gerrit.wikimedia.org/r/246450

Change 246450 merged by jenkins-bot:
Remove custom quicksearch hook

https://gerrit.wikimedia.org/r/246450

Change 249028 had a related patch set uploaded (by Eileen):
Add test for contact.merge action

https://gerrit.wikimedia.org/r/249028

Change 249034 had a related patch set uploaded (by Eileen):
add test for contact.merge action

https://gerrit.wikimedia.org/r/249034

Change 249034 merged by jenkins-bot:
add test for contact.merge action

https://gerrit.wikimedia.org/r/249034

Hmm - I have found I need to set some permissions (merge contacts & delete contacts) on the test user. Not sure if there is a precedent for that in the suite

We are going to look at merge separately & the contactListQuery has been removed but the others are worth doing.

Change 252481 had a related patch set uploaded (by Eileen):
add test for contact.merge action

https://gerrit.wikimedia.org/r/252481

Change 252481 merged by Eileen:
add test for contact.merge action

https://gerrit.wikimedia.org/r/252481

Eileenmcnaughton closed this task as Resolved.Nov 18 2015, 12:54 AM

I'm setting this to resolved cos I think that's what we agreed to do with it. Big picture adding tests = good

Change 249028 abandoned by Eileen:
Add test for contact.merge action

Reason:
I'm going to ditch this - it fixes some enotices that block tests - but until we are actively doing those tests it feels like noise

https://gerrit.wikimedia.org/r/249028

Change 285774 had a related patch set uploaded (by Eileen):
add test for contact.merge action

https://gerrit.wikimedia.org/r/285774

Change 285774 merged by Eileen:
add test for contact.merge action

https://gerrit.wikimedia.org/r/285774