Page MenuHomePhabricator
Create Task
Maniphest T115426

All Civi hook code paths must be covered by PHPUnit tests
Closed, ResolvedPublic
Actions

Description

  • wmf_civicrm_civicrm_merge
  • wmf_civicrm_civicrm_post
  • wmf_civicrm_civicrm_contactListQuery
  • wmf_civicrm_civicrm_buildForm
  • wmf_civicrm_civicrm_validate

Details

SubjectRepoBranchLines +/-
add test for contact.merge actionwikimedia/fundraising/civicrm-corecivi-4.6.9+33 -10
Add test for contact.merge actionwikimedia/fundraising/civicrm-corecivi-4.6.9+45 -10
add test for contact.merge actionwikimedia/fundraising/civicrm-coremaster+33 -10
add test for contact.merge actionwikimedia/fundraising/crm/civicrmcivi-4.6.9+33 -10
Remove custom quicksearch hookwikimedia/fundraising/crmcivi-4.6.9+0 -79
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Oct 13 2015, 11:44 PM
awight raised the priority of this task from to Medium.
awight updated the task description. (Show Details)
awight added projects: Fundraising Sprint UB40, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2015, 11:44 PM
Eileenmcnaughton claimed this task.Oct 14 2015, 8:10 PM
Eileenmcnaughton moved this task from Backlog to Doing on the Fundraising Sprint UB40 board.
Eileenmcnaughton set Security to None.
• DStrine moved this task from Triage to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Oct 14 2015, 9:32 PM
• DStrine added a project: Fundraising Sprint Vengaboys.Oct 14 2015, 11:17 PM
gerritbot subscribed.Oct 15 2015, 12:36 AM

Change 246450 had a related patch set uploaded (by Eileen):
Remove custom quicksearch hook

https://gerrit.wikimedia.org/r/246450

gerritbot added a project: Patch-For-Review.Oct 15 2015, 12:36 AM
gerritbot added a comment.Oct 15 2015, 7:06 PM

Change 246450 merged by jenkins-bot:
Remove custom quicksearch hook

https://gerrit.wikimedia.org/r/246450

gerritbot added a comment.Oct 26 2015, 11:59 PM

Change 249028 had a related patch set uploaded (by Eileen):
Add test for contact.merge action

https://gerrit.wikimedia.org/r/249028

gerritbot added a comment.Oct 27 2015, 12:10 AM

Change 249034 had a related patch set uploaded (by Eileen):
add test for contact.merge action

https://gerrit.wikimedia.org/r/249034

gerritbot added a comment.Oct 27 2015, 12:17 AM

Change 249034 merged by jenkins-bot:
add test for contact.merge action

https://gerrit.wikimedia.org/r/249034

Eileenmcnaughton moved this task from Backlog to Doing on the Fundraising Sprint Vengaboys board.Oct 27 2015, 2:05 AM
Eileenmcnaughton added a comment.Oct 27 2015, 7:28 AM

Hmm - I have found I need to set some permissions (merge contacts & delete contacts) on the test user. Not sure if there is a precedent for that in the suite

• DStrine added a project: Fundraising Sprint William Shatner.Oct 28 2015, 10:58 PM
Eileenmcnaughton removed a project: Fundraising Sprint William Shatner.Nov 6 2015, 6:45 PM

We are going to look at merge separately & the contactListQuery has been removed but the others are worth doing.

• DStrine added a project: Fundraising Sprint X-Ray Spex.Nov 10 2015, 6:08 PM
awight moved this task from Backlog to Done on the Fundraising Sprint X-Ray Spex board.Nov 10 2015, 9:46 PM
gerritbot added a comment.Nov 11 2015, 6:20 PM

Change 252481 had a related patch set uploaded (by Eileen):
add test for contact.merge action

https://gerrit.wikimedia.org/r/252481

gerritbot added a comment.Nov 14 2015, 12:22 AM

Change 252481 merged by Eileen:
add test for contact.merge action

https://gerrit.wikimedia.org/r/252481

Eileenmcnaughton closed this task as Resolved.Nov 18 2015, 12:54 AM

I'm setting this to resolved cos I think that's what we agreed to do with it. Big picture adding tests = good

gerritbot added a comment.Jan 22 2016, 11:22 PM

Change 249028 abandoned by Eileen:
Add test for contact.merge action

Reason:
I'm going to ditch this - it fixes some enotices that block tests - but until we are actively doing those tests it feels like noise

https://gerrit.wikimedia.org/r/249028

gerritbot added a comment.Apr 27 2016, 11:43 PM

Change 285774 had a related patch set uploaded (by Eileen):
add test for contact.merge action

https://gerrit.wikimedia.org/r/285774

gerritbot added a comment.Apr 27 2016, 11:51 PM

Change 285774 merged by Eileen:
add test for contact.merge action

https://gerrit.wikimedia.org/r/285774

• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL