Using context variable when usable instead of globals
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	TasneemLo
	Oct 14 2015, 3:50 AM

Description

As mentioned in T89682

Using globals ($wgUser, $wgRequest) when their context equivalents could be used instead ($this->getUser(), $this->getRequest()) should give an error and fixit

Related Objects

Mentioned In: T130382: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki
Mentioned Here: T89682: Improving static analysis tools for MediaWiki

Event Timeline

TasneemLo created this task.Oct 14 2015, 3:50 AM

TasneemLo raised the priority of this task from to Needs Triage.

TasneemLo updated the task description. (Show Details)

TasneemLo subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2015, 3:50 AM

Hi @TasneemLo. Please associate at least one project with this task, otherwise one cannot find this task when searching in the corresponding project(s). Is this about MediaWiki-Codesniffer? Thanks!

TasneemLo added a project: MediaWiki-Codesniffer.Oct 15 2015, 3:41 AM

TasneemLo set Security to None.

TasneemLo unsubscribed.Dec 20 2015, 9:16 AM

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 20 2015, 9:16 AM

Aashaka mentioned this in T130382: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki.Mar 18 2016, 5:00 PM

Happen by the MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage sniff - https://gerrit.wikimedia.org/r/#/c/301335/

Umherirrender closed this task as Resolved.Jul 11 2017, 8:38 PM

Umherirrender triaged this task as Medium priority.

Using context variable when usable instead of globalsClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Using context variable when usable instead of globals
Closed, ResolvedPublic
Actions