Page MenuHomePhabricator
Create Task
Maniphest T115436

ResourcesTest::testFileExistence does not ignore anchor in url
Closed, ResolvedPublic
Actions

Description

upstream library contains the anchor in url in its style :

@font-face
{
...
src: ..., url('./fonts/slick.svg#slick') format('svg');
}

https://gerrit.wikimedia.org/r/#/c/246154/1/resources/libs/slick/slick-theme.css

And Jenkins reports failure when testing it:

ResourcesTest::testFileExistence with data set #477 ( ...blablabla... ./fonts/slick.svg#slick')
File '...blablabla... /fonts/slick.svg#slick' referenced by 'ext.PhpTagsWidgets.slick' must exist.
Failed asserting that file "...blablabla... /fonts/slick.svg#slick" exists.

https://integration.wikimedia.org/ci/job/mwext-PhpTagsWidgets-testextension-zend/33/console

I do not know for what the anchor there and whether I need to fix it.
May be ResourcesTest::testFileExistence should ignore anchor in url, doesn't it?

Details

SubjectRepoBranchLines +/-
resourceloader: CSSMin::getLocalFileReferences now strips anchorsmediawiki/coreREL1_31+48 -5
Ignore fragment of file name after anchor in ResourcesTestmediawiki/coremaster+6 -0
Migrate Refreshed skin to Quibbleintegration/configmaster+1 -5
(DO NOT SUBMIT) test case for T115436mediawiki/skins/Refreshedmaster+0 -0
resourceloader: CSSMin::getLocalFileReferences now strips anchorsmediawiki/coremaster+48 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pastakhov created this task.Oct 14 2015, 5:42 AM
Pastakhov raised the priority of this task from to Needs Triage.
Pastakhov updated the task description. (Show Details)
Pastakhov subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2015, 5:42 AM
Pastakhov updated the task description. (Show Details)Oct 14 2015, 5:42 AM
Pastakhov set Security to None.
Pastakhov added a project: Jenkins.
Krenair added projects: MediaWiki-ResourceLoader, MediaWiki-Core-Tests.Oct 14 2015, 9:26 AM
Krenair subscribed.
hashar removed a project: Jenkins.Oct 14 2015, 12:33 PM
hashar subscribed.

That is not a Jenkins issue but the extension PhpTagsWidgets not confirming to MediaWiki core resource loader expectations. See in core the 'structure' PHPUnit suite which you can run with:

php tests/phpunit.php --testsuite structure
hashar unsubscribed.Oct 14 2015, 12:34 PM
Pastakhov added a comment.Oct 22 2015, 8:39 AM

www.w3.org says:

An IRI which includes an IRI fragment identifier consists of an optional base IRI, followed by a "#" character, followed by the IRI fragment identifier.

So, ResourcesTest::testFileExistence should be fixed.

gerritbot subscribed.Oct 22 2015, 9:01 AM

Change 247998 had a related patch set uploaded (by Pastakhov):
Ignore fragment of file name after anchor in ResourcesTest

https://gerrit.wikimedia.org/r/247998

gerritbot added a project: Patch-For-Review.Oct 22 2015, 9:01 AM
Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.Dec 14 2015, 9:20 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 14 2015, 9:20 PM
Krinkle triaged this task as Low priority.Dec 14 2015, 9:20 PM
Krinkle assigned this task to Pastakhov.Mar 15 2017, 2:08 AM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:12 AM
hashar mentioned this in T154806: Skin Refreshed sub repo does not handled in test config.Aug 2 2017, 1:56 PM
hashar added a project: Refreshed.
hashar subscribed.
In T154806#3493335, @hashar wrote:

The Jenkins job now process submodules. The MediaWiki test fails to find WikiFont-Glyphs.svg#wikiglyph because of the anchor :-/

Umherirrender added a parent task: T134090: fix or mark as inactive extensions currently failing CI.Nov 4 2017, 9:59 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptNov 4 2017, 9:59 PM
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.Nov 6 2017, 8:42 PM
Krinkle edited projects, added Performance-Team; removed Performance-Team (Radar).Nov 17 2017, 9:17 PM
Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.
Krinkle changed the task status from Open to Stalled.Jan 18 2018, 10:45 AM
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
Umherirrender added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Apr 13 2018, 7:12 PM
Umherirrender removed a parent task: T134090: fix or mark as inactive extensions currently failing CI.Apr 13 2018, 7:21 PM
Krinkle removed a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Apr 13 2018, 8:18 PM
Krinkle removed Pastakhov as the assignee of this task.May 4 2018, 2:10 AM
Krinkle removed a project: Patch-For-Review.
Krinkle subscribed.

@Pastakhov I am un-assigning this given it has been two years. That way, it can be seen as available for someone else interested in this. Feel free to re-assign it if/when you have time available to work on this. Thanks!

Krinkle changed the task status from Stalled to Open.May 4 2018, 2:10 AM
hashar assigned this task to TheDJ.Jun 5 2018, 2:16 PM

That got fixed between 1.29 and 1.30. Fixed by 032f0ce8cb513dd07ad77156a4630a9712654214

CSSMin: Skip #default#behaviorName when detecting local files

Bug: T162973
Change-Id: If76869910f308f8a91c73f287e7e74c214f02e9b

hashar closed this task as a duplicate of T162973: Add support for behavior: url(#default#behaviorName).Jun 5 2018, 2:18 PM
Krinkle reopened this task as Open.EditedJun 5 2018, 5:52 PM

@hashar I do not think that is a duplicate. This task is about arbitrary values after #, specifically for anchoring inside SVG files. Such as url(fonts/Foo.svg#bar) has to be indexed by ResourceLoader as dependency on a file: fonts/Foo.svg.

On the other hand, task T162973 is not about files and anchors, it is about the whole url being an magic value that looks like an anchor, the exact value url(#default#behaviorName). For T162973 the solution was to ignore those urls entirely because they are not dependencies on real files.

For this task, the problem still happens in master, and the solution will have to be to keep the file but strip the anchor.

gerritbot added a comment.Jul 17 2018, 4:02 PM

Change 446352 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/core@master] CSSMin::getLocalFileReferences now strips anchors

https://gerrit.wikimedia.org/r/446352

gerritbot added a project: Patch-For-Review.Jul 17 2018, 4:02 PM

Change 446353 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/skins/Refreshed@master] (DO NOT SUBMIT) test case for T115436

https://gerrit.wikimedia.org/r/446353

hashar claimed this task.Jul 17 2018, 4:04 PM
hashar added a subscriber: TheDJ.

@Krinkle thank you! I got confused by how similar the two tasks are :] I eventually crafted a patch that would strip the anchors entirely.

Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJul 17 2018, 4:04 PM
hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jul 17 2018, 4:07 PM
hashar added a parent task: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
hashar mentioned this in R1893:e82813b500d6: (DO NOT SUBMIT) test case for T115436.Jul 17 2018, 4:10 PM
Krinkle closed this task as Resolved.Jul 20 2018, 4:42 AM

Thanks!

gerritbot added a comment.Jul 20 2018, 4:59 AM

Change 446352 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: CSSMin::getLocalFileReferences now strips anchors

https://gerrit.wikimedia.org/r/446352

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 20 2018, 5:00 AM
gerritbot added a comment.Jul 20 2018, 7:20 AM

Change 447032 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Migrate Refreshed skin to Quibble

https://gerrit.wikimedia.org/r/447032

gerritbot added a comment.Jul 20 2018, 7:20 AM

Change 446353 abandoned by Hashar:
(DO NOT SUBMIT) test case for T115436

https://gerrit.wikimedia.org/r/446353

hashar mentioned this in R1893:96ddcb435283: (DO NOT SUBMIT) test case for T115436.Jul 20 2018, 7:20 AM
gerritbot added a comment.Jul 20 2018, 7:22 AM

Change 447032 merged by jenkins-bot:
[integration/config@master] Migrate Refreshed skin to Quibble

https://gerrit.wikimedia.org/r/447032

gerritbot added a comment.Sep 14 2020, 10:13 AM

Change 247998 abandoned by Thiemo Kreuz (WMDE):
[mediawiki/core@master] Ignore fragment of file name after anchor in ResourcesTest

Reason:
This code doesn't exist any more since Iae46b2d, the task is closed as resolved.

https://gerrit.wikimedia.org/r/247998

Restricted Application added a subscriber: MacFan4000. · View Herald TranscriptSep 14 2020, 10:13 AM
gerritbot added a comment.Jan 3 2021, 7:25 PM

Change 653744 had a related patch set uploaded (by Legoktm; owner: Hashar):
[mediawiki/core@REL1_31] resourceloader: CSSMin::getLocalFileReferences now strips anchors

https://gerrit.wikimedia.org/r/653744

gerritbot added a comment.Jan 3 2021, 7:43 PM

Change 653744 merged by jenkins-bot:
[mediawiki/core@REL1_31] resourceloader: CSSMin::getLocalFileReferences now strips anchors

https://gerrit.wikimedia.org/r/653744

ReleaseTaggerBot added a project: MW-1.31-release-notes.Jan 3 2021, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL