Page MenuHomePhabricator

ext.wikimediaEvents throws JS exception on mobile
Closed, ResolvedPublic

Description

Error: Unknown dependency: jquery.jStorage Error: Unknown dependency: jquery.jStorage(…)

ext.wikimediaEvents.search.js:51
It's using jQuery.jStorage this is not available on mobile and we have no plans to support it. Use the standard mediawiki.storage instead.

Not sure what's adding this to mobile but am seeing it on every page https://en.m.wikipedia.org/wiki/Special:Gather/id/9230/Predestination_(2014)
https://en.m.wikipedia.org/wiki/Juan_el_de_la_Vara#/random

I have no idea if it's breaking anything but it's highly possible.

Event Timeline

Jdlrobson raised the priority of this task from to Unbreak Now!.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.
Jdlrobson set Security to None.

I'm guessing this might have something to do with the Discovery team and only impact a sample of users?

This is probably related to https://meta.wikimedia.org/wiki/Schema:Search. I wasn't aware that was actually running on mobile web.

That's probably not Schema:Search, because that one isn't using jStorage. It's more likely to be Schema:TestSearchSatisfaction. That brings in jStorage for the sample of users opted into the tests. Due to the way ext.wikimediaEvents is setup I'm not sure how to get things loaded only for the desktop site without adding a new non-mobile wikimediaEvents and waiting 30 days for cache's to clear.

I'll poke some people and see if they have any ideas.

Deskana lowered the priority of this task from Unbreak Now! to High.Oct 15 2015, 4:44 PM

Actually, this has been happening for quite a while. It's not a super-pressing issue, but it is something that needs fixing because spamming logs is bad. We plan to look at this in the next few days.

to clarify, T116319 is removing the dependency on jquery.jStorage which is causing this error, along with putting in an early exit for the mobile site.