ext.wikimediaEvents throws JS exception on mobile
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Oct 15 2015, 12:16 AM

Description

Error: Unknown dependency: jquery.jStorage Error: Unknown dependency: jquery.jStorage(…)

ext.wikimediaEvents.search.js:51
It's using jQuery.jStorage this is not available on mobile and we have no plans to support it. Use the standard mediawiki.storage instead.

Not sure what's adding this to mobile but am seeing it on every page https://en.m.wikipedia.org/wiki/Special:Gather/id/9230/Predestination_(2014)
https://en.m.wikipedia.org/wiki/Juan_el_de_la_Vara#/random

I have no idea if it's breaking anything but it's highly possible.

Related Objects

Mentioned Here: T116319: Fix and re-deploy satisfaction schema.

Event Timeline

Jdlrobson created this task.Oct 15 2015, 12:16 AM

Jdlrobson raised the priority of this task from to Unbreak Now!.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: MediaWiki-extensions-WikimediaEvents.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2015, 12:16 AM

I'm guessing this might have something to do with the Discovery team and only impact a sample of users?

This is probably related to https://meta.wikimedia.org/wiki/Schema:Search. I wasn't aware that was actually running on mobile web.

• Deskana added a project: Discovery-Search (Current work).Oct 15 2015, 3:45 PM

That's probably not Schema:Search, because that one isn't using jStorage. It's more likely to be Schema:TestSearchSatisfaction. That brings in jStorage for the sample of users opted into the tests. Due to the way ext.wikimediaEvents is setup I'm not sure how to get things loaded only for the desktop site without adding a new non-mobile wikimediaEvents and waiting 30 days for cache's to clear.

I'll poke some people and see if they have any ideas.

Actually, this has been happening for quite a while. It's not a super-pressing issue, but it is something that needs fixing because spamming logs is bad. We plan to look at this in the next few days.

• ksmith added a project: Essential-Work.Oct 16 2015, 9:18 PM

• ksmith moved this task from Needs triage to On Sprint Board on the Discovery-ARCHIVED board.Oct 19 2015, 10:22 PM

this is being fixed as part of T116319

This makes sense to do at the same time as T116319: Fix and re-deploy satisfaction schema.

EBernhardson moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Oct 29 2015, 4:40 PM

to clarify, T116319 is removing the dependency on jquery.jStorage which is causing this error, along with putting in an early exit for the mobile site.

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Nov 12 2015, 5:36 PM

• Deskana closed this task as Resolved.Dec 17 2015, 5:45 AM

• Deskana moved this task from Needs Reporting to Resolved on the Discovery-Search (Current work) board.Jan 28 2016, 6:10 PM

ext.wikimediaEvents throws JS exception on mobile Closed, ResolvedPublicActions

Description

Related Objects

Event Timeline

ext.wikimediaEvents throws JS exception on mobile
Closed, ResolvedPublic
Actions