Maniphest T115781

Grep for func_get_arg()/func_get_args() and fix an HHVM reference bugs
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	aaron
	Oct 17 2015, 7:37 AM

Tags

Referenced Files

None

Subscribers

View All 10 Subscribers

Description

See https://github.com/facebook/hhvm/issues/1027 . We have lots of uses in core alone. Make sure none of them are broken by this HHVM behavior.

This caused some test failures on version of https://gerrit.wikimedia.org/r/#/c/244374/ that took some debugging to track.

Related Objects

Mentioned In: T118683: 1.27-alpha / TitleMoveComplete-closure has invalid call signature
Mentioned Here: T192166: Drop HHVM support from MediaWiki

Event Timeline

aaron created this task.Oct 17 2015, 7:37 AM

aaron raised the priority of this task from to Needs Triage.

aaron updated the task description. (Show Details)

aaron added projects: MediaWiki-General, HHVM.

aaron subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 17 2015, 7:37 AM

aaron updated the task description. (Show Details)Oct 17 2015, 7:39 AM

aaron set Security to None.

Krenair subscribed.Oct 17 2015, 5:55 PM

ori merged a task: T118683: 1.27-alpha / TitleMoveComplete-closure has invalid call signature.Mar 8 2016, 1:10 AM

ori added subscribers: ori, Nikerabbit, Glaisher and 2 others.

mwjames mentioned this in T118683: 1.27-alpha / TitleMoveComplete-closure has invalid call signature.Mar 8 2016, 9:21 AM

Ricordisamoa subscribed.Sep 23 2016, 9:55 AM

Obsolete per T192166.