Page MenuHomePhabricator

Have a second Gerrit (Code Review backlog) cleanup day
Closed, DeclinedPublic

Description

We had a first Gerrit cleanup day in September (T88531) which was mildly successful: We reduced the queue of patchsets without any review by 18% (25% for those submitted in last 3 months) and we learned a lot about (social and technical) aspects of Code Review.

It makes sense to iterate by repeating the Cleanup Day experiment in late February / early March 2016 incorporating T113378: Lessons learned from the first Gerrit Cleanup Day plus T101686: Goal: Define potential actions to reduce code review queues and waiting times/T78768: Agree on and implement actions to prioritize code review of patches submitted by volunteers.

We should also use this opportunity to improve awareness and knowledge about Differential's workflows across the developer community.
Related: T114311: [keyresult] Code review RFC (Differential) - Write, publish, publicize, and respond to/incorporate feedback./T119908: [RfC]: Migrate code review / management from Gerrit to Phabricator.

Event Timeline

Aklapper raised the priority of this task from to Needs Triage.
Aklapper updated the task description. (Show Details)
Aklapper added a subscriber: Aklapper.
Ricordisamoa added a subscriber: Ricordisamoa.
Qgil triaged this task as Low priority.Oct 19 2015, 5:35 PM
Qgil moved this task from To triage to January-March 2016 on the Developer-Advocacy board.
Qgil added a subscriber: Qgil.
Jay8g added a subscriber: Jay8g.Oct 20 2015, 5:38 AM
Aklapper set Security to None.

I've moved this from January to February because I don't see having time for this in January, and I'd like to concentrate first on improving the underlying code review situation via https://phabricator.wikimedia.org/T78768 and https://phabricator.wikimedia.org/T101686 instead of spending too much time on a Cleanup Day band-aid.

Aklapper updated the task description. (Show Details)Dec 29 2015, 6:07 PM
Aklapper claimed this task.Jan 19 2016, 7:07 PM
Aklapper added a project: DevRel-March-2016.

Given lots of other stuff on my list taking longer than expected due to many reasons, I'd like to postpone working on this task to April-June 2016.
If anybody else would like to run a second Gerrit cleanup day earlier, I'm happy to help and support such efforts.

Aklapper lowered the priority of this task from Low to Lowest.Feb 24 2016, 2:55 PM
saper added a subscriber: saper.Apr 17 2016, 8:09 PM
Qgil added a comment.Jun 1 2016, 6:39 PM

Now that there are weekly code review office hours, is it still considered a good idea to have a Gerrit Cleanup Day? (or Differential)

Now that there are weekly code review office hours, is it still considered a good idea to have a Gerrit Cleanup Day? (or Differential)

Question is whether actually 'enough' long-waiting unreviewed patches with unclear code area maintenance get tackled in the code review office hours, or if it's more like patches which fir with personal interest and are not overly complex...

Still this task is currently lowest priority. Personally prefer to work on underlying issues than symptoms. Hence I'll move this to the Backlog but anyone else is free and encouraged to lead a Cleanup Day and I am happy to support efforts.

Aklapper closed this task as Declined.Sep 12 2016, 1:04 PM

I'm going to decline this lingering task.
Developer-Advocacy currently has no plans and capacity to organize this in the foreseeable future.
Instead we want fo tackle underlying issues (see T129067, in the field of the Release-Engineering-Team) and experiment with some nudging via weekly reminders (see T137214).

If someone wants to organize a second Gerrit cleanup day Developer-Advocacy are happy to help.