Page MenuHomePhabricator
Create Task
Maniphest T115844

Have a second Gerrit (Code Review backlog) cleanup day
Closed, DeclinedPublic
Actions

Description

We had a first Gerrit cleanup day in September (T88531) which was mildly successful: We reduced the queue of patchsets without any review by 18% (25% for those submitted in last 3 months) and we learned a lot about (social and technical) aspects of Code Review.

It makes sense to iterate by repeating the Cleanup Day experiment in late February / early March 2016 incorporating T113378: Lessons learned from the first Gerrit Cleanup Day plus T101686: Goal: Define potential actions to reduce code review queues and waiting times/T78768: Agree on and implement actions to prioritize code review of patches submitted by volunteers.

We should also use this opportunity to improve awareness and knowledge about Differential's workflows across the developer community.
Related: T114311: [keyresult] Code review RFC (Differential) - Write, publish, publicize, and respond to/incorporate feedback./T119908: [RfC]: Migrate code review / management from Gerrit to Phabricator.

Related Objects

Event Timeline

Aklapper created this task.Oct 19 2015, 11:13 AM
Aklapper raised the priority of this task from to Needs Triage.
Aklapper updated the task description. (Show Details)
Aklapper added projects: DevRel-January-2016, Developer-Advocacy.
Aklapper mentioned this in T113378: Lessons learned from the first Gerrit Cleanup Day.
Aklapper subscribed.
Ricordisamoa awarded a token.Oct 19 2015, 2:01 PM
Ricordisamoa subscribed.
Qgil triaged this task as Low priority.Oct 19 2015, 5:35 PM
Qgil moved this task from To triage to January-March 2016 on the Developer-Advocacy board.
Qgil subscribed.
Jay8g subscribed.Oct 20 2015, 5:38 AM
Ladsgroup subscribed.Oct 22 2015, 11:56 AM
Aklapper edited projects, added DevRel-February-2016; removed DevRel-January-2016.Dec 13 2015, 10:03 PM
Aklapper set Security to None.
Aklapper added a comment.Dec 13 2015, 10:05 PM

I've moved this from January to February because I don't see having time for this in January, and I'd like to concentrate first on improving the underlying code review situation via https://phabricator.wikimedia.org/T78768 and https://phabricator.wikimedia.org/T101686 instead of spending too much time on a Cleanup Day band-aid.

Aklapper updated the task description. (Show Details)Dec 29 2015, 6:07 PM
Aklapper claimed this task.Jan 19 2016, 7:07 PM
Aklapper added a project: DevRel-March-2016.
Aklapper added a comment.Feb 24 2016, 2:11 PM

Given lots of other stuff on my list taking longer than expected due to many reasons, I'd like to postpone working on this task to April-June 2016.
If anybody else would like to run a second Gerrit cleanup day earlier, I'm happy to help and support such efforts.

Aklapper edited projects, added DevRel-April-2016; removed DevRel-March-2016.Feb 24 2016, 2:20 PM
Aklapper moved this task from January-March 2016 to Proposed: July - September 2016 on the Developer-Advocacy board.
Aklapper moved this task from Proposed: July - September 2016 to Proposed: April-June 2016 on the Developer-Advocacy board.
Aklapper lowered the priority of this task from Low to Lowest.Feb 24 2016, 2:55 PM
Qgil edited projects, added Developer-Advocacy (Apr-Jun-2016); removed Developer-Advocacy.Apr 1 2016, 2:43 PM
Aklapper moved this task from Apr-Jun-2016 to Jul-Sep-2016 on the Developer-Advocacy board.Apr 2 2016, 7:56 AM
Aklapper edited projects, added Developer-Advocacy (Jul-Sep-2016); removed Developer-Advocacy (Apr-Jun-2016).
saper subscribed.Apr 17 2016, 8:09 PM
Qgil added a comment.Jun 1 2016, 6:39 PM

Now that there are weekly code review office hours, is it still considered a good idea to have a Gerrit Cleanup Day? (or Differential)

Qgil moved this task from Backlog to Ready to Go on the Developer-Advocacy (Jul-Sep-2016) board.Jul 5 2016, 9:10 PM
Aklapper edited projects, added Developer-Advocacy; removed Developer-Advocacy (Jul-Sep-2016).Aug 1 2016, 8:58 AM
In T115844#2345870, @Qgil wrote:

Now that there are weekly code review office hours, is it still considered a good idea to have a Gerrit Cleanup Day? (or Differential)

Question is whether actually 'enough' long-waiting unreviewed patches with unclear code area maintenance get tackled in the code review office hours, or if it's more like patches which fir with personal interest and are not overly complex...

Still this task is currently lowest priority. Personally prefer to work on underlying issues than symptoms. Hence I'll move this to the Backlog but anyone else is free and encouraged to lead a Cleanup Day and I am happy to support efforts.

Aklapper moved this task from Proposed: April-June 2016 to To triage on the Developer-Advocacy board.Aug 1 2016, 9:01 AM
Aklapper closed this task as Declined.Sep 12 2016, 1:04 PM

I'm going to decline this lingering task.
Developer-Advocacy currently has no plans and capacity to organize this in the foreseeable future.
Instead we want fo tackle underlying issues (see T129067, in the field of the Release-Engineering-Team) and experiment with some nudging via weekly reminders (see T137214).

If someone wants to organize a second Gerrit cleanup day Developer-Advocacy are happy to help.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits