| Ryasmeen | |
| Oct 19 2015, 10:41 PM |
| F34892954: Screen Shot 2021-12-22 at 8.49.11 AM.png | |
| Dec 22 2021, 5:21 PM |
| F2738276: Screen Shot 2015-10-19 at 3.41.11 PM.png | |
| Oct 19 2015, 10:41 PM |
Steps to reproduce:
1.Go to Upload media dialog
2.After selecting an image when you are in the media settings dialog for the details section reduce the window size in a way that it overlaps with the calendar
Observe that, there is no scroll bar appearing so cant select the dates that are below the border
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| CalendarWidget: Make clippable, scrollable | mediawiki/core | master | +58 -2 |
Ideas @matmarex shared for addressing this:
- Make the calendar scrollable, as is done in the Search for contributions > Namespace: https://en.wikipedia.org/wiki/Special:Contributions/PPelberg_(WMF) [i]
- Have the calendar appear above the field, rather than below
i.
Comparing this with another widget which uses a popup (DropdownWidget), it looks like MenuSelectWidget.js:477 contains the code responsible for automatically flipping the direction that the menu appears when the dropdown is activated. It relies that ClippableElement is mixed in, however (since it needs to know whether or not the dialog will get clipped vertically, and that function is only exposed within ClippableElement). So the idea of making the calendar clippable/scrollable would solve both the issues with it being clipped when too close to the bottom of the screen and also allow the calendar to flip when the space below it is too little. A demonstration for this can be found with P51429. Not sure if this is the best solution for this yet so I've kept it a paste for now; do tell if this should be turned into a patch.
There could be other ways of fixing this, such as adding just the check to see when the calendar gets cut off by the viewport. This removes the scrolling (which could be an unwanted effect given that this is a calendar and not a dropdown menu) but doesn't handle a case where the calendar may be squeezed between a narrow space (but realistically this isn't a justifiable edge case; little to no one would have the window at 300px tall). Any thoughts on this?
I tried out your patch and it works and makes sense to me. I'd be happy to merge that change if you submit it. Thanks for looking into it!
I don't really know why that wasn't done before, it might have been just laziness more effort than we wanted to put into this interface. It's also possible that someone really disliked the scrolling when the calendar is clipped, but you're right that it will probably never happen in practice, so it doesn't seem worth trying to improve it.
Change 953356 had a related patch set uploaded (by Chlod Alejandro; author: Chlod Alejandro):
[mediawiki/core@master] CalendarWidget: Make clippable, scrollable
Change 953356 merged by jenkins-bot:
[mediawiki/core@master] CalendarWidget: Make clippable, scrollable
