Page MenuHomePhabricator

[Regression] 404 Not Found: https://en.wikipedia.org/apple-touch-icon.png
Closed, ResolvedPublic

Description

This used to work, but recently (last few months, sorry can't be more specific) stopped working.

The rewrite for favicon.ico still works, and the same rewrite does work for non-Wikipedia sites.

Should be covered by https://github.com/wikimedia/operations-puppet/blob/812f280d16acfe3083259e8dfa7ce12ebf71da87/modules/mediawiki/files/apache/sites/public-wiki-rewrites.incl#L7-L10

# Configurable favicon
RewriteRule ^/favicon\.ico$ /w/favicon.php [L]
# Configurable apple-touch-icon.png
RewriteRule ^/apple-touch-icon\.png$ /w/touch.php [L]

Event Timeline

Krinkle raised the priority of this task from to High.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Regression, acl*sre-team.
Krinkle added a subscriber: Krinkle.

the one public-wiki-rewrites.incl above seems to cover wikimedia-related virtualhosts, not wikipedias. I guess we have at least two options:

  • add apple-touch-icon rewrites to modules/mediawiki/files/apache/sites/main.conf
  • further refactor favicon/robots out of main.conf and include public-wiki-rewrites for wikipedias too

cc @Joe since he might have more context on this and general apache config refactor

Change 256437 had a related patch set uploaded (by Reedy):
Fix apple-touch-icon.png on wikipedias

https://gerrit.wikimedia.org/r/256437

the one public-wiki-rewrites.incl above seems to cover wikimedia-related virtualhosts, not wikipedias. I guess we have at least two options:

  • add apple-touch-icon rewrites to modules/mediawiki/files/apache/sites/main.conf
  • further refactor favicon/robots out of main.conf and include public-wiki-rewrites for wikipedias too

cc @Joe since he might have more context on this and general apache config refactor

I think he just got busy, and stuff wasn't finished.

In the patch above I've removed the stuff that is added by public-wiki-rewrites, so that keeps that functionality, but also fixes the apple-touch-icon.png not working

https://gerrit.wikimedia.org/r/256440 is for other Wiki projects that have the $wgAppleTouchIcon defined. Might aswell fix them up as they're broken too

Change 256437 merged by Giuseppe Lavagetto:
Fix apple-touch-icon.png on wikipedias

https://gerrit.wikimedia.org/r/256437

Reedy claimed this task.