Page MenuHomePhabricator
Create Task
Maniphest T115972

[Bug] Add reference button on new statements does not work
Closed, ResolvedPublic
Actions

Description

When pressing a ›new statement‹ button, an empty statement in edit mode is added. This statement has an expanded, empty references section. The ›add reference‹ button does not work, but throws an error, because the new referenceview did not get passed in a required statementGuid.

Details

SubjectRepoBranchLines +/-
[DNM] Make Add reference button work in new statementmediawiki/extensions/Wikibasemaster+20 -6
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedLydia_PintscherT87759 [Story] Allow simultaneous editing of mainsnak and references
ResolvedadrianheineT115972 [Bug] Add reference button on new statements does not work
OpenNoneT115974 [Task] Browser tests for reference adding on new statements
· · ·

Event Timeline

adrianheine created this task.Oct 20 2015, 7:52 AM
adrianheine raised the priority of this task from to Medium.
adrianheine updated the task description. (Show Details)
adrianheine added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2015, 7:52 AM
adrianheine mentioned this in T87759: [Story] Allow simultaneous editing of mainsnak and references .Oct 20 2015, 8:18 AM
matej_suchanek subscribed.Oct 20 2015, 11:35 AM

Existed as T108008

gerritbot subscribed.Oct 21 2015, 12:04 PM

Change 247820 had a related patch set uploaded (by Adrian Lang):
[DNM] Make Add reference button work in new statement

https://gerrit.wikimedia.org/r/247820

gerritbot added a project: Patch-For-Review.Oct 21 2015, 12:04 PM
• Jonas mentioned this in T116153: [Task] The referenceview must work with no statement GUID .Oct 21 2015, 12:25 PM
matej_suchanek mentioned this in T116480: Adding references on Wikidata causes "Uncaught Error: Required option not specified properly".Oct 24 2015, 6:39 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-10-13.Nov 3 2015, 10:24 AM
Tobi_WMDE_SW set Security to None.
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2015-10-13 board.
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-11-03.Nov 3 2015, 12:41 PM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2015-11-03 board.
adrianheine added a project: MediaWiki-extensions-WikibaseView.Nov 4 2015, 8:13 AM
• Jonas assigned this task to adrianheine.Nov 4 2015, 1:45 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Nov 8 2015, 5:04 PM
matej_suchanek merged a task: T118142: Problems trying to add reference or to save new Wikidata statement.Nov 9 2015, 2:21 PM
matej_suchanek added subscribers: Mbch331, • Spage, StudiesWorld.
• Jonas closed this task as Resolved.Nov 10 2015, 4:30 PM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2015-11-03 board.
gerritbot added a comment.Nov 13 2015, 1:58 PM

Change 247820 merged by jenkins-bot:
[DNM] Make Add reference button work in new statement

https://gerrit.wikimedia.org/r/247820

matej_suchanek removed a project: Patch-For-Review.Dec 21 2015, 2:07 PM
matej_suchanek removed subscribers: gerritbot, matej_suchanek.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL