Page MenuHomePhabricator

Gadget Merge.js generates warning "Unrecognized value for parameter 'ignoreconflicts': label"
Closed, ResolvedPublic


The Wikidata gadget Merge.js uses currently

ignoreconflicts: 'description|label', // ignore descriptions and labels conflicts as old version of merge did

which generates the warning

"warnings":{"wbmergeitems":{"*":"Unrecognized value for parameter 'ignoreconflicts': label"}}

Was there a change that dropped support for 'ignoreconflicts': label? Or was this never supported? Is this related to T115892?

Event Timeline

Fomafix created this task.Oct 20 2015, 8:52 AM
Fomafix raised the priority of this task from to Needs Triage.
Fomafix updated the task description. (Show Details)
Fomafix added a project: Wikidata-Gadgets.
Fomafix added a subscriber: Fomafix.
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 20 2015, 8:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Fomafix reopened this task as Open.Oct 20 2015, 9:25 AM

I guess this is complete independent to T115892. The support for ignoreconflicts: label was removed in 80f161f9 on Dec 11 2014. I suppose the warning appears since December 2014.

To prevent the warning the parameter |label in Merge.js line 630 have to removed.

I already did it but then it was reverted...

Fomafix triaged this task as Low priority.Oct 20 2015, 11:35 AM

Just a harmless warning.

I already did it but then it was reverted...

Your edit was just between my attempts to fix T107275 :)

Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Oct 20 2015, 2:26 PM
Fomafix closed this task as Resolved.Oct 20 2015, 2:39 PM
Fomafix claimed this task.

I removed the option ignoreconflicts: 'label' (diff). The warning in the API response is now gone.

matej_suchanek removed a subscriber: matej_suchanek.