Page MenuHomePhabricator

Support MP4 audio files when $wgTmhEnableMp4Uploads on (AAC in .m4a or .mp4)
Open, Needs TriagePublic

Description

Current support for MP4 (AAC) audio-only files is pretty spotty in TMH.

Event Timeline

brion created this task.Oct 20 2015, 10:32 PM
brion raised the priority of this task from to Needs Triage.
brion updated the task description. (Show Details)
brion added a project: TimedMediaHandler.
brion added a subscriber: brion.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2015, 10:32 PM

Change 247750 had a related patch set uploaded (by Brion VIBBER):
Work in progress support for .m4a audio-only files

https://gerrit.wikimedia.org/r/247750

TheDJ added a subscriber: TheDJ.Nov 13 2015, 1:35 PM

this shouldn't be too hard to round up, I did a bit more prototyping in the areas where this was going wrong.
Now we need a good deal of sample files to wrap it up correctly.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 13 2015, 1:35 PM
TheDJ added a comment.Nov 14 2015, 4:09 PM

Hmm, if we want the "codecs" generation to be somewhat accurate, it seems we will have to fix getID3.

avc1 .  followed by three bytes
1: profile_idc
2: the byte containing the constraint_set flags
3: level_idc.

These bytes are in the moov.trak.mdia.minf.stbl.stsd.avc1.avcC atom, which apparently isn't read by getID3

[mpv4|mp4a] . ObjectTypeIndication . [ProfileLevelIndication|AudioObjectTypeIndication]

ObjectTypeIndication: http://www.mp4ra.org/object.html
AudioObjectTypeIndication:
VideoProfileLevelIndication: