Page MenuHomePhabricator

Turn Similar Pages / Page Issues into a native component.
Closed, ResolvedPublic3 Estimated Story Points

Description

We need to make the "Similar pages" and "Page issues" items into native buttons. This will serve as a prerequisite for T114523 and T114524, since those buttons will live alongside the disambiguation/issues buttons.

I imagine that this native strip of buttons can simply be an extension of the existing LeadImageContainer. (and the WebView can pass the hatnote/issues data to the native component when the page loads)
Visually it should look something like this:

icon-alternative-05.png (1×722 px, 193 KB)

Whether the buttons will be just an icon, or an icon with text, is still TBD.

Event Timeline

Dbrant raised the priority of this task from to Medium.
Dbrant updated the task description. (Show Details)
Dbrant moved this task to Next Sprint on the Wikipedia-Android-App-Backlog board.
Dbrant subscribed.
MBinder_WMF set Security to None.
MBinder_WMF edited a custom field.

Change 252589 had a related patch set uploaded (by Niedzielski):
Hygiene: refactor lead image parallax scrolling

https://gerrit.wikimedia.org/r/252589

Change 252589 merged by jenkins-bot:
Hygiene: refactor lead image parallax scrolling

https://gerrit.wikimedia.org/r/252589

Change 253065 had a related patch set uploaded (by Niedzielski):
Hygiene: move lead parallax to Drawable matrix

https://gerrit.wikimedia.org/r/253065

Change 253065 merged by jenkins-bot:
Hygiene: move lead parallax to Drawable matrix

https://gerrit.wikimedia.org/r/253065

Change 254112 had a related patch set uploaded (by Niedzielski):
Make page issues and disambiguations native

https://gerrit.wikimedia.org/r/254112

Change 254112 abandoned by Niedzielski:
Make page issues and disambiguations native

Reason:
To be continued...

https://gerrit.wikimedia.org/r/254112

Change 258213 merged by jenkins-bot:
Move content issues and disambiguations to menu

https://gerrit.wikimedia.org/r/258213

Checked with 2.1.136-alpha-2015-12-15 on Nexus 5 (Android 5.1.1)
From https://gerrit.wikimedia.org/r/#/c/258213/

Move content issues and similar titles to page menu and move save pages
and share a link to the article toolbar.

Articles with 'Page issues'

Screenshot_2015-12-15-15-22-44.png (1×1 px, 372 KB)

Screenshot_2015-12-15-15-44-44.png (1×1 px, 653 KB)

Screenshot_2015-12-15-15-54-16.png (1×1 px, 533 KB)

Screenshot_2015-12-15-15-54-01.png (1×1 px, 537 KB)

vs 2.1.134-r-2015-11-12

Screenshot_2015-12-15-15-48-18.png (1×1 px, 388 KB)

Screenshot_2015-12-15-15-51-18 (1).png (1×1 px, 691 KB)

Checked with 2.1.136-alpha-2015-12-15 on Nexus 5 (Android 5.1.1)

Article with 'Similar pages'

Screenshot_2015-12-15-16-05-32.png (1×1 px, 297 KB)

Screenshot_2015-12-15-15-55-20.png (1×1 px, 233 KB)