Page MenuHomePhabricator

[Regression pre-wmf.4] Triggering some sequences leaves artifacts in the DOM
Closed, ResolvedPublic8 Story Points

Description

The change from T113797 (c65b032da5bda2c59059d12494934533320ff1dd) seems to have introduced a bug in sequence expansion, where the input that triggers the sequence isn't always removed from the DOM. It is, however, removed from the model.

The list item sequence exhibits this. (New-paragraph, enter * , see that we get • * instead of just .)

It's not universal; the link sequence doesn't do this.

Event Timeline

DLynch created this task.Oct 21 2015, 2:49 PM
DLynch raised the priority of this task from to Needs Triage.
DLynch updated the task description. (Show Details)
DLynch added subscribers: DLynch, dchan.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2015, 2:49 PM
Jdforrester-WMF triaged this task as High priority.Oct 21 2015, 3:19 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF added a subscriber: Esanders.

Looks like we aren't re-rendering after a sequence has been triggered.

Change 247865 had a related patch set uploaded (by Esanders):
ve.ce.Surface: Defer checkSequences call for insertText as well

https://gerrit.wikimedia.org/r/247865

Esanders claimed this task.Oct 21 2015, 5:57 PM
Jdforrester-WMF renamed this task from Triggering some sequences leaves artifacts in the DOM to [Regression pre-wmf.4] Triggering some sequences leaves artifacts in the DOM.Oct 21 2015, 10:50 PM
Jdforrester-WMF closed this task as Resolved.

Change 247865 merged by jenkins-bot:
ve.ce.Surface: Defer checkSequences call for insertText as well

https://gerrit.wikimedia.org/r/247865