Page MenuHomePhabricator

Cannot edit any image because while trying to edit an existing image, instead of "Apply Changes", there is now "Upload" button
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:
1.Insert an image
2.Save the page
3.Reopen the page with VE
4.Select an already added image
5.Click on Edit from the context menu

Observe that, in the media settings dialog the button on the top right is not "Apply Changes" anymore, it's "Upload"
So if you make any changes to it , its not anymore applicable to that image

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : wmf/1.27.0-wmf.3ve.ui.MWMediaDialog: Move upload booklet init further up
mediawiki/extensions/VisualEditor : masterve.ui.MWMediaDialog: Move upload booklet init further up

Event Timeline

Ryasmeen created this task.Oct 21 2015, 7:39 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen added a subscriber: Ryasmeen.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2015, 7:39 PM
Ryasmeen triaged this task as High priority.Oct 21 2015, 7:39 PM
Ryasmeen set Security to None.
Ryasmeen updated the task description. (Show Details)Oct 21 2015, 7:42 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptOct 22 2015, 5:10 PM

Like with T116219, this only happens the first time you open the dialog.

Change 248083 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ui.MWMediaDialog: Move upload booklet init further up

https://gerrit.wikimedia.org/r/248083

Change 248083 merged by jenkins-bot:
ve.ui.MWMediaDialog: Move upload booklet init further up

https://gerrit.wikimedia.org/r/248083

Jdforrester-WMF closed this task as Resolved.Oct 22 2015, 6:20 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.

Change 248247 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ui.MWMediaDialog: Move upload booklet init further up

https://gerrit.wikimedia.org/r/248247

Change 248247 merged by jenkins-bot:
ve.ui.MWMediaDialog: Move upload booklet init further up

https://gerrit.wikimedia.org/r/248247