Page MenuHomePhabricator

Provide better error message when a Score is empty
Closed, ResolvedPublic1 Estimated Story Points

Description

Entering <score>\relative c' {}</score> produces an error, which states:

'No MIDI file generated despite being requested. If you are working in raw LilyPond mode, make sure to provide a proper \midi block.'

This is a bit confusing to the user as they didn't explicitly request a MIDI file.

The error is more likely to occur in the VisualEditor score inspector.

Revisions and Commits

Event Timeline

Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders subscribed.
Esanders renamed this task from Provide better error message when invalid syntax entered to Provide better error message when emp.Oct 23 2015, 4:53 PM
Esanders updated the task description. (Show Details)
Esanders added a project: VisualEditor.
Esanders set Security to None.
Jdforrester-WMF renamed this task from Provide better error message when emp to Provide better error message when empty.Oct 23 2015, 4:57 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF edited a custom field.
Jdforrester-WMF renamed this task from Provide better error message when empty to Provide better error message when a Score is empty.Nov 10 2015, 8:27 PM
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Esanders lowered the priority of this task from High to Low.Nov 19 2015, 6:51 PM
Ebe123 subscribed.

How about just a rendering error that says that it's an empty score. That is what my patch Upstream does: http://codereview.appspot.com/332470043. We then would have one fewer message to deal with.

The other possibility is to move score-noimages just above the MIDI option block in the PNG generation function.

Change 399868 had a related patch set uploaded (by Ebe123; owner: Ebe123):
[mediawiki/extensions/Score@master] Make image check precede MIDI check

https://gerrit.wikimedia.org/r/399868

Change 399868 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Make image check precede MIDI check

https://gerrit.wikimedia.org/r/399868

Jdforrester-WMF changed the point value for this task from 1 to 8.Jan 16 2018, 6:25 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF changed the point value for this task from 8 to 1.