Page MenuHomePhabricator
Create Task
Maniphest T116428

Rework TMH's HTML output for video/audio transforms to be more forward-compatible
Closed, DeclinedPublic
Actions

Description

The HTML output of the audio/video elements, their container, and their subelements, is currently kinda specific to the transformation with the Kaltura player... especially the popup transform mode that drops a big blob of HTML in an attribute.

Should clean up the HTML to be cleaner, and usable as a base for both old Kaltura player and VideoJS. Probably clean up the popup transform mode so it doesn't stick in all that stuff in the attribute... either load it separately (maybe via embed iframe?) or properly embed it in the markup tree.

Scrawling some notes at https://www.mediawiki.org/wiki/User:Brion_VIBBER/Media_rendering_encapsulation_2

Related Objects
Search...

Event Timeline

• brion created this task.Oct 23 2015, 8:01 PM
• brion claimed this task.
• brion raised the priority of this task from to Medium.
• brion updated the task description. (Show Details)
• brion added a project: TimedMediaHandler.
• brion moved this task to Doing on the TimedMediaHandler board.
• brion subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2015, 8:01 PM
• brion added a comment.Oct 24 2015, 12:00 AM

Going back to older notes in https://www.mediawiki.org/wiki/User:Brion_VIBBER/Media_rendering_encapsulation ... A couple key things:

  • need to be able to specify the source resource by name -- there's no 'a' link around a video or audio to get it from.
    • expanding the parsoid image spec we'd perhaps put the 'resource' attribute onto the audio/video/canvas/iframe/div ... but I see no spec for that attribute in HTML5. Would we have to use an mw-data attrib or something?
    • stuff like the packed-gallery resizing code (see T77988) needs to be able to reference the actual element and adjust width/height... How much can we rely on the structure when fetching those elements?

General note:

  • should we handle the 'popup' logic entirely client-side? Eg always embed a video element even for for small sizes, but take over the click handler in JS to move/copy it to a popup?
TheDJ added a parent task: T131188: Add support to choose which player you want in preference.Apr 1 2016, 7:15 PM
TheDJ subscribed.May 13 2016, 11:40 AM
In T116428#1749869, @brion wrote:

General note:

  • should we handle the 'popup' logic entirely client-side? Eg always embed a video element even for for small sizes, but take over the click handler in JS to move/copy it to a popup?

This is what I'm currently going for with https://gerrit.wikimedia.org/r/#/c/285075/ and I'm hopeful that I might even be able to use that for both MwEmbedPlayer AND VideoJS.

TheDJ created subtask T135603: Remove output of poster attribute for <audio> elements.May 18 2016, 10:17 AM
TheDJ closed subtask T135603: Remove output of poster attribute for <audio> elements as Resolved.Jun 22 2016, 4:41 PM
• brion closed this task as Declined.Jan 20 2018, 12:49 AM

We ended up going with a parser cache key tweak / version check instead. Seems ok so far.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL