Page MenuHomePhabricator

Strip Parsoid/RESTbase's ids when copying between VE surfaces as they will clash and break things
Closed, ResolvedPublic1 Story Points

Description

VE seems to create tables unnecessarily mixing wiki syntax and HTML syntax, with other problems at the same time. Please fix.
https://en.wikipedia.org/w/index.php?title=Chimelong_Paradise&type=revision&diff=687199846&oldid=687181243
https://fr.wikipedia.org/w/index.php?title=Stoffel_Vandoorne&type=revision&diff=119456957&oldid=119456276
https://en.wikipedia.org/w/index.php?title=Far_East_Consortium_International_Limited&diff=prev&oldid=687088735

Among the noted problems :

  • Table is partly in wiki syntax, partly in HTML syntax
  • Strange href in the middle of the table
  • Title with h3 tags instead of wiki syntax
  • Bolding is in HTML syntax, even with a xml:lang attribute (?) and a strange value
  • ...

Event Timeline

NicoV created this task.Oct 24 2015, 8:19 AM
NicoV raised the priority of this task from to Needs Triage.
NicoV updated the task description. (Show Details)
NicoV added projects: VisualEditor, Parsoid.
NicoV added a subscriber: NicoV.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 24 2015, 8:19 AM
ssastry set Security to None.

@GWicke, @Esanders, @Jdforrester-WMF copy-paste that reuses ids causing incorrect use of data-parsoid? We've seen this on occasion in the past.

NicoV added a comment.EditedOct 25 2015, 5:02 PM

User JaJaWa reports that the table layout was copied from the page on FR wiki for the following edit
https://en.wikipedia.org/w/index.php?title=Chimelong_Paradise&type=revision&diff=687199846&oldid=687181243

For information, the page on FR wiki has none of the problems reported, so the problems are created by VE/Parsoid
https://fr.wikipedia.org/wiki/Chimelong_Paradise

ssastry renamed this task from Tables mixing wiki and HTML syntax + other problems to VE / RESTBase: Incorrect id reuse after copy-paste?.Oct 25 2015, 5:18 PM
ssastry moved this task from Backlog to Non-Parsoid Tasks on the Parsoid board.Oct 28 2015, 4:57 PM
Jdforrester-WMF renamed this task from VE / RESTBase: Incorrect id reuse after copy-paste? to Strip Parsoid/RESTbase's ids when copying between VE surfaces as they will clash and break things.Nov 17 2015, 8:25 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Change 254449 had a related patch set uploaded (by Esanders):
Paste sanitisation: Strip RESTBase IDs when pasting

https://gerrit.wikimedia.org/r/254449

Change 254449 merged by jenkins-bot:
Paste sanitisation: Strip Parsoid IDs when pasting

https://gerrit.wikimedia.org/r/254449