Page MenuHomePhabricator
Create Task
Maniphest T116460

Strip Parsoid/RESTbase's ids when copying between VE surfaces as they will clash and break things
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

VE seems to create tables unnecessarily mixing wiki syntax and HTML syntax, with other problems at the same time. Please fix.
https://en.wikipedia.org/w/index.php?title=Chimelong_Paradise&type=revision&diff=687199846&oldid=687181243
https://fr.wikipedia.org/w/index.php?title=Stoffel_Vandoorne&type=revision&diff=119456957&oldid=119456276
https://en.wikipedia.org/w/index.php?title=Far_East_Consortium_International_Limited&diff=prev&oldid=687088735

Among the noted problems :

  • Table is partly in wiki syntax, partly in HTML syntax
  • Strange href in the middle of the table
  • Title with h3 tags instead of wiki syntax
  • Bolding is in HTML syntax, even with a xml:lang attribute (?) and a strange value
  • ...

Details

SubjectRepoBranchLines +/-
Paste sanitisation: Strip Parsoid IDs when pastingVisualEditor/VisualEditormaster+45 -9
Customize query in gerrit

Related Objects

Event Timeline

NicoV created this task.Oct 24 2015, 8:19 AM
NicoV raised the priority of this task from to Needs Triage.
NicoV updated the task description. (Show Details)
NicoV added projects: VisualEditor, Parsoid.
NicoV subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 24 2015, 8:19 AM
Bgwhite subscribed.Oct 24 2015, 8:44 AM
ssastry added a project: RESTBase.Oct 24 2015, 12:51 PM
ssastry set Security to None.
ssastry added subscribers: • GWicke, Esanders, Jdforrester-WMF, ssastry.

@GWicke, @Esanders, @Jdforrester-WMF copy-paste that reuses ids causing incorrect use of data-parsoid? We've seen this on occasion in the past.

NicoV added a comment.EditedOct 25 2015, 5:02 PM

User JaJaWa reports that the table layout was copied from the page on FR wiki for the following edit
https://en.wikipedia.org/w/index.php?title=Chimelong_Paradise&type=revision&diff=687199846&oldid=687181243

For information, the page on FR wiki has none of the problems reported, so the problems are created by VE/Parsoid
https://fr.wikipedia.org/wiki/Chimelong_Paradise

ssastry renamed this task from Tables mixing wiki and HTML syntax + other problems to VE / RESTBase: Incorrect id reuse after copy-paste?.Oct 25 2015, 5:18 PM
ssastry merged a task: T116525: Prevent iOS Safari and other browsers' plugins from converting numbers into `tel:xyz` links.
NicoV mentioned this in T116525: Prevent iOS Safari and other browsers' plugins from converting numbers into `tel:xyz` links.Oct 25 2015, 5:46 PM
• GWicke added a comment.Oct 26 2015, 4:42 PM

See also:

https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec/Element_IDs#On_copy_or_view_page_load.2C_add_a_revision_URL_attribute_attribute_to_at_least_one_element

ssastry mentioned this in T113173: Edits to/near headings are being serialised as <h3> rather than \n===.Oct 28 2015, 4:29 PM
ssastry merged a task: T113173: Edits to/near headings are being serialised as <h3> rather than \n===.
ssastry added a subscriber: • Elitre.
ssastry moved this task from Needs Triage to Non-Parsing-Team Tasks on the Parsoid board.Oct 28 2015, 4:57 PM
Jdforrester-WMF renamed this task from VE / RESTBase: Incorrect id reuse after copy-paste? to Strip Parsoid/RESTbase's ids when copying between VE surfaces as they will clash and break things.Nov 17 2015, 8:25 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF edited projects, added VisualEditor-CopyPaste, VisualEditor-MediaWiki; removed RESTBase, Parsoid.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
ssastry mentioned this in T119145: Copy-Paste: VE should add rev-id attributes to content pasted from other wikipages.Nov 19 2015, 11:19 PM
gerritbot subscribed.Nov 20 2015, 7:08 PM

Change 254449 had a related patch set uploaded (by Esanders):
Paste sanitisation: Strip RESTBase IDs when pasting

https://gerrit.wikimedia.org/r/254449

gerritbot added a project: Patch-For-Review.Nov 20 2015, 7:08 PM
gerritbot added a comment.Nov 20 2015, 7:52 PM

Change 254449 merged by jenkins-bot:
Paste sanitisation: Strip Parsoid IDs when pasting

https://gerrit.wikimedia.org/r/254449

Jdforrester-WMF closed this task as Resolved.Nov 20 2015, 8:33 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)); removed Patch-For-Review.
NicoV mentioned this in T201607: VE mixing HTML and wikitext syntax for tables.Aug 9 2018, 12:49 PM
matmarex mentioned this in T108506: Copy-paste of table from VE into another VE sometimes serialises with HTML elements and weird "href" attributes on cells.Aug 31 2018, 7:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL