draws Vector's light-blue border in the middle of a page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Spage
	Oct 25 2015, 2:57 AM

Description

Parsoid's HTML output, e.g. https://en.wikipedia.org/api/rest_v1/page/html/Parsing, has a blue border visible on the left and "bottom" that appears part-way down the page:

parsoid_blue_border_bug.png (368×473 px, 57 KB)

This comes from Parsoid requesting RL module skins.vector.styles, which incorporates Vector's components/common.less, which has:

html,
body {
    height: 100%;
...
}
/* Content */
.mw-body {
    margin-left: 10em;
    padding: @content-padding;
    /* Border on top, left, and bottom side */
    border: 1px solid @content-border-color;
    border-right-width: 0;
    /* Merge the border with tabs' one (in their background image) */
    margin-top: -1px;
   ...
}

There are two bugs here: a) somehow height: 100% ends up way less than the actual height of the article; b) the blue border on mw-body is pointless without Vector's grey mw-head, mw-panel sidebar, and footer. a) I can't figure out; the computed height seems always 409.5px in Firefox and 1028px in chromium. b) Parsoid has to use mw-body because of the way Vector/components/common.less is structured, so it needs to clear this border and maybe other properties, e.g. the wide left margin.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Arlolra	T116508 /rest_v1/page/html/ draws Vector's light-blue border in the middle of a page
		Resolved		dr0ptp4kt	T68461 Vector: Use standard classes like .mw-body in stylesheets instead of custom ids like #content

Event Timeline

• Spage created this task.Oct 25 2015, 2:57 AM

• Spage raised the priority of this task from to Needs Triage.

• Spage updated the task description. (Show Details)

• Spage added projects: Parsoid-Rendering, Parsoid.

• Spage subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2015, 2:57 AM

Arlolra added a subtask: T68461: Vector: Use standard classes like .mw-body in stylesheets instead of custom ids like #content.Nov 18 2015, 3:04 AM

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 18 2015, 3:04 AM

Arlolra triaged this task as Low priority.Nov 18 2015, 3:05 AM

Arlolra subscribed.

There are two bugs here:
a.1) somehow height: 100% ends up way less than the actual height of the article;
a.2) I can't figure out; the computed height seems always 409.5px in Firefox and 1028px in chromium.
This comes from Parsoid requesting RL module skins.vector.styles, which incorporates Vector's components/common.less, which has:

html,
body {
    height: 100%;
...
}

If I force the same .css settings locally, I get the same thing as described (getting viewport height rather than document height). Once I 'separate the two' and let <body> "use" either the agent's default(s) or let it inherit an attribute value from the root <html>'s setting(s), the quirky height dimensions stopped.

Frankly I can't see the point of 'making settings' that "high up'' in the document.structure unless its to force or override another setting for the 'remaining' document or something. Why bother to set height: to 100% when in this case that attribute carries a setting of auto to begin with?

dr0ptp4kt closed subtask T68461: Vector: Use standard classes like .mw-body in stylesheets instead of custom ids like #content as Resolved.Jul 7 2016, 8:40 PM

Arlolra closed this task as a duplicate of T155863: MediaWiki has "content" styles applying only inside .mw-body, making them not reusable.Apr 10 2017, 5:53 PM

This was closed as duplicate of T155863, but that task is resolved, and it seems like this task isn't (I still see a blue border in https://en.wikipedia.org/api/rest_v1/page/html/Parsing).

@matmarex Oh, sorry, I was going off of the comment you left here https://gerrit.wikimedia.org/r/#/c/158803/

Hm, I think I was also confused when writing that, these two bugs have a similar cause but they're not the same.

Change 347605 had a related patch set uploaded (by Arlolra):
[mediawiki/services/parsoid@master] T116508: Remove .mw-body from Parsoid content

https://gerrit.wikimedia.org/r/347605

gerritbot added a project: Patch-For-Review.Apr 11 2017, 1:16 PM

Change 347605 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T116508: Remove .mw-body from Parsoid content

https://gerrit.wikimedia.org/r/347605

Arlolra closed this task as Resolved.Apr 26 2017, 3:57 PM

Arlolra claimed this task.

Mentioned in SAL (#wikimedia-operations) [2017-04-26T21:05:49Z] <arlolra> Updated Parsoid to 4949857a (T116508, T64270, T133673)

Stashbot mentioned this in T64270: Support video and audio content.Apr 26 2017, 9:05 PM

Stashbot mentioned this in T133673: Add width/height attributes to the <audio><video> tag.

/rest_v1/page/html/ draws Vector's light-blue border in the middle of a pageClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

/rest_v1/page/html/ draws Vector's light-blue border in the middle of a page
Closed, ResolvedPublic
Actions

Related Objects
Search...