Page MenuHomePhabricator

SpaceyParenthesis bug
Closed, DuplicatePublic

Description

In the media-wiki code sniffer, there is a Sniff - MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
When running the sniff on $a->foo( $b );, PHPCS mentions that it has found an issue on that line. It further says that it can fix this issue.

When I run phpcbf to fix the issue - I get an error which says the fix could not be applied - and it fails.

Event Timeline

TasneemLo raised the priority of this task from to Needs Triage.
TasneemLo updated the task description. (Show Details)
TasneemLo added a subscriber: TasneemLo.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2015, 7:56 AM

Hi @TasneemLo. Please associate at least one project with this task, otherwise nobody can find this task when searching in the corresponding project(s). Thanks.

What is a "fixit"? Where in which codebase can this be found?

Sorry about that - it's part of MediaWiki-Codesniffer

TasneemLo set Security to None.
TasneemLo updated the task description. (Show Details)Oct 25 2015, 9:27 AM
Krinkle renamed this task from SpaceyParanthesis bug to SpaceyParenthesis bug.Oct 27 2015, 5:23 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 20 2015, 9:15 AM

Hi, actually I meet this situation also so that I have submitted my changes about it just now.