Page MenuHomePhabricator
Create Task
Maniphest T116601

"Cards"/"RelatedArticles" extension should be able to render uniform cards in a desktop skin
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Currently this can only be used in mobile skins (Minerva).

  • ext.cards.gateway should work with targets desktop without pulling mobile modules.

Desktop experience should be feature flagged and disabled by default.

desktop-17-17.png (662×1 px, 124 KB)

Details

SubjectRepoBranchLines +/-
Display cards in desktop view toomediawiki/extensions/Cardsmaster+65 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Oct 26 2015, 3:44 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: MediaWiki-extensions-Cards.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2015, 3:44 PM
Jdlrobson renamed this task from ext.cards.gateway should work with targets desktop to "Cards" extension should be able to render uniform cards in a desktop skin.Oct 26 2015, 3:44 PM
Jdlrobson added a parent task: T113635: Implement first version of read more.
Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.
Jdlrobson mentioned this in T114393: "Cards" extension should be able to render uniform cards in mobile skin.Oct 26 2015, 3:49 PM
Jdlrobson added a parent task: T113747: [placeholder] Optimise read more for desktop.
Jdlrobson added a project: Reading Web Sprint 59 - Amsterdam and the hamsters.Oct 26 2015, 10:41 PM
Jdlrobson edited a custom field.
Jdlrobson triaged this task as Low priority.Oct 26 2015, 11:57 PM
Jdlrobson removed a parent task: T113635: Implement first version of read more.Oct 27 2015, 7:27 PM
Jdlrobson added a parent task: T94906: [EPIC] Read more related articles after end of current article.
Jdlrobson removed a parent task: T94906: [EPIC] Read more related articles after end of current article.Oct 29 2015, 9:08 PM
Jdlrobson added a parent task: T117108: [Placeholder] Related articles should be dependent on Cards.
• bmansurov mentioned this in T117137: Add watchstar to cards.Oct 30 2015, 12:06 AM
Jdlrobson added a project: Reading Web Sprint 60 - Boom Headshot!.Nov 2 2015, 5:27 PM
Jdlrobson renamed this task from "Cards" extension should be able to render uniform cards in a desktop skin to "Cards"/"RelatedArticles" extension should be able to render uniform cards in a desktop skin.Nov 2 2015, 5:30 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson merged a task: T113747: [placeholder] Optimise read more for desktop.
Jdlrobson added subscribers: • KLans_WMF, • JKatzWMF, phuedx, • KHammerstein.
Jdlrobson updated the task description. (Show Details)Nov 2 2015, 5:34 PM
Jdlrobson removed a project: Reading Web Sprint 59 - Amsterdam and the hamsters.Nov 2 2015, 5:47 PM
• bmansurov updated the task description. (Show Details)Nov 9 2015, 5:16 PM
• KLans_WMF edited a custom field.Nov 9 2015, 5:20 PM
• KLans_WMF moved this task from Needs Analysis to To Do on the Reading Web Sprint 60 - Boom Headshot! board.
• bmansurov claimed this task.Nov 10 2015, 10:28 AM
• bmansurov moved this task from To Do to Doing on the Reading Web Sprint 60 - Boom Headshot! board.
gerritbot added a subscriber: gerritbot.Nov 10 2015, 5:17 PM

Change 252210 had a related patch set uploaded (by Bmansurov):
Display cards in desktop view too

https://gerrit.wikimedia.org/r/252210

gerritbot added a project: Patch-For-Review.Nov 10 2015, 5:17 PM
• bmansurov moved this task from Doing to Code Review on the Reading Web Sprint 60 - Boom Headshot! board.Nov 10 2015, 5:19 PM
• bmansurov mentioned this in T117444: RelatedArticles feature should be available in beta features.Nov 12 2015, 3:26 AM
phuedx removed a subtask: T117444: RelatedArticles feature should be available in beta features.Nov 12 2015, 10:09 AM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading Web Sprint 60 - Boom Headshot! board.Nov 13 2015, 2:05 PM
• bmansurov moved this task from -1 (Needs More Work) to Doing on the Reading Web Sprint 60 - Boom Headshot! board.Nov 14 2015, 2:30 AM
• bmansurov added a comment.Nov 16 2015, 1:47 AM

@phuedx, I left a comment on the patch. I'd like to hear what you think before I do anything.

• bmansurov moved this task from Doing to To Do on the Reading Web Sprint 60 - Boom Headshot! board.Nov 16 2015, 1:50 AM
• bmansurov moved this task from To Do to Doing on the Reading Web Sprint 60 - Boom Headshot! board.
• bmansurov moved this task from Doing to Code Review on the Reading Web Sprint 60 - Boom Headshot! board.Nov 17 2015, 11:29 AM
phuedx added a comment.Nov 17 2015, 11:51 AM

@bmansurov: I've archived our earlier IRC chat about this ticket here: P2315.

• bmansurov added a comment.Nov 17 2015, 11:51 AM

Thanks!

phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading Web Sprint 60 - Boom Headshot! board.Nov 17 2015, 1:20 PM
• bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading Web Sprint 60 - Boom Headshot! board.Nov 17 2015, 4:20 PM
gerritbot added a comment.Nov 17 2015, 7:48 PM

Change 252210 merged by jenkins-bot:
Display cards in desktop view too

https://gerrit.wikimedia.org/r/252210

phuedx moved this task from Code Review to Ready for Signoff on the Reading Web Sprint 60 - Boom Headshot! board.Nov 17 2015, 8:08 PM

We must create a task to track the whole "Should MobileFrontend/core be using Hogan.js? How do we share the Muhogan code if not?" conversation before this task is moved to Done.

• bmansurov added a comment.Nov 18 2015, 1:16 AM

Here it is: T118923

• bmansurov added a subscriber: • jhobs.Nov 19 2015, 5:37 PM

@jhobs, could you please sign off on this task as Sam and I worked on it and we may miss something obvious? Thanks.

phuedx added a comment.Nov 19 2015, 5:39 PM

I never fail to miss something obvious.

• jhobs closed this task as Resolved.Nov 23 2015, 12:41 PM

LGTM

Screen Shot 2015-11-23 at 7.39.19 AM.png (300×1 px, 38 KB)

• jhobs moved this task from Ready for Signoff to Done on the Reading Web Sprint 60 - Boom Headshot! board.Nov 23 2015, 12:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL