TranslateRenderJob: "Oops, this should not happen!"
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• demon
	Oct 26 2015, 5:20 PM

Description

Spotted in production:

[
  {
    "file": "/srv/mediawiki/php-1.27.0-wmf.3/extensions/Translate/tag/PageTranslationHooks.php",
    "line": 159,
    "function": "run",
    "class": "TranslateRenderJob",
    "type": "->",
    "args": []
  },
  {
    "file": "/srv/mediawiki/php-1.27.0-wmf.3/extensions/Translate/tag/PageTranslationHooks.php",
    "line": 139,
    "function": "updateTranslationPage",
    "class": "PageTranslationHooks",
    "type": "::",
    "args": [
      "TranslatablePage",
      "string",
      "User",
      "integer",
      "string"
    ]
  },
  {
    "file": "/srv/mediawiki/php-1.27.0-wmf.3/includes/Hooks.php",
    "line": 204,
    "function": "onSectionSave",
    "class": "PageTranslationHooks",
    "type": "::",
    "args": [
      "WikiPage",
      "User",
      "WikitextContent",
      "string",
      "integer",
      "NULL",
      "NULL",
      "integer",
      "NULL"
    ]
  },
  {
    "file": "/srv/mediawiki/php-1.27.0-wmf.3/includes/page/WikiPage.php",
    "line": 1963,
    "function": "run",
    "class": "Hooks",
    "type": "::",
    "args": [
      "string",
      "array"
    ]
  },
  {
    "file": "/srv/mediawiki/php-1.27.0-wmf.3/extensions/Translate/utils/MessageUpdateJob.php",
    "line": 44,
    "function": "doEditContent",
    "class": "WikiPage",
    "type": "->",
    "args": [
      "WikitextContent",
      "string",
      "integer",
      "boolean",
      "User"
    ]
  },
  {
    "file": "/srv/mediawiki/php-1.27.0-wmf.3/includes/jobqueue/JobRunner.php",
    "line": 180,
    "function": "run",
    "class": "MessageUpdateJob",
    "type": "->",
    "args": []
  },
  {
    "file": "/srv/mediawiki/rpc/RunJobs.php",
    "line": 42,
    "function": "run",
    "class": "JobRunner",
    "type": "->",
    "args": [
      "array"
    ]
  }
]

Related Objects

Mentioned Here: T59541: TranslateRenderJob.php: Oops, this should not happen!

Event Timeline

• demon created this task.Oct 26 2015, 5:20 PM

• demon raised the priority of this task from to Medium.

• demon updated the task description. (Show Details)

• demon added projects: Wikimedia-production-error, MediaWiki-extensions-Translate.

• demon subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2015, 5:20 PM

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Oct 26 2015, 5:22 PM

Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.Nov 3 2015, 3:48 PM

Krinkle unsubscribed.Nov 11 2015, 8:51 PM

aaron raised the priority of this task from Medium to High.Dec 11 2015, 1:24 PM

This was previously worked on T59541: TranslateRenderJob.php: Oops, this should not happen!

17 events today, 12 events two days ago. Does not justify high priority imho.

The latest events correspond with these log actions, the latter has same time.

14:23, 11 December 2015 Piramidion (talk | contribs) marked Wikimedia Russia for translation
14:21, 11 December 2015 Piramidion (talk | contribs) removed Wikimedia Russia from translation

Should these just result in the job just calling setError() and returning false? Maybe it could no longer be an exception?

This probably can't happen anymore from MessageUpdateJobs (when marking for translation, at least) once https://gerrit.wikimedia.org/r/#/c/281698/ and https://gerrit.wikimedia.org/r/#/c/282695/ reaches the wikis (will be deployed on next update). When pages are marked for translation, the render job will only be run once per language and the value of marked tag is also not cached during reads so an invalid value cached before the updates are not used.

The exception message was recently modified so this error message won't occur anymore. Note that there would've been a spike of this earlier this month on group0 wikis due to a recently introduced change but that was quickly fixed.
Let's hope that this is now fixed (after the above patches) and close this task. If it does occur again, I guess someone will open another task with the new error message.

• demon moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.Jul 20 2016, 1:45 AM

TranslateRenderJob: "Oops, this should not happen!"Closed, ResolvedPublicActions

Description

Related Objects

Event Timeline

TranslateRenderJob: "Oops, this should not happen!"
Closed, ResolvedPublic
Actions