Page MenuHomePhabricator

MediaWiki CI tests should run with allow_url_fopen set to false
Open, MediumPublic


Code using "data://" URLs requires allow_url_fopen to be enabled, which is not required (and not very good in general for the production setup).

Can we make sure we run tests with this disabled?

I catched (line 69)

and today.

Event Timeline

saper raised the priority of this task from to Medium.
saper updated the task description. (Show Details)
saper added subscribers: saper, hashar.

You probably want to disable it explicitly in tests/phpunit/MediaWikiTestCase.php setUp() method.

Haven't tested the effect though.

@hashar bad news, allow_url_fopen is settable only in the system-wide php.ini file:

On the Jenkins slaves, the php.ini should be the same as the one used on Wikimedia production.

Seems we can pass the setting via PHP -d. Using 5.3.29:

$ php -a
Interactive shell

php > var_dump( ini_get('allow_url_fopen') );
string(1) "1"

php > var_dump( ini_set('allow_url_fopen', 0) );

php > var_dump( ini_get('allow_url_fopen') );
string(1) "1"

So yeah we can not use ini_set. But:

$ php -a -d allow_url_fopen=0
Interactive shell

php > var_dump( ini_get('allow_url_fopen') );
string(1) "0"
php >

One possibility would be to have an addition ini files to be populated via puppet under /etc/php5/cli/conf.d/. But then it will apply to any php runs.

Maybe we can craft a specific ini file that would be in integration/jenkins.git under /etcthen update the various wrapping scripts we have in /bin to refer to it.

So we would update the various /bin/mw-run-phpunit* scripts to refer to it:

php -c /srv/deployment/integration/slave-scripts/etc/php-mw-ci.ini \
    ... rest of stuff ...