Page MenuHomePhabricator

On French Wikipedia, the gadget that collapses templates should run after the user saves their edit to restore their default state
Closed, ResolvedPublic1 Estimated Story Points

Description

Screencast - Feedback

User case

  1. Edit an article with collapsible templates
  2. Change something anywhere, save
    1. Collapsible templates are open
    2. Action links are not displayed
  3. You need to refresh page to have the default state

Tested on frwp (problem), itwp (no problem) and enwp (no problem).

Event Timeline

Trizek-WMF raised the priority of this task from to Needs Triage.
Trizek-WMF updated the task description. (Show Details)
Trizek-WMF added a project: VisualEditor.
Trizek-WMF added a subscriber: Trizek-WMF.

The script which collapses the templates on frwp probably needs fixing. I'd compare it to the working ones on enwp and itwp.

Jdforrester-WMF renamed this task from On French WIkipedia, collapsible templates should at their default state when you've saved your edit to On French Wikipedia, the gadget that collapses templates should run after the user saves their edit to restore their default state.Nov 10 2015, 8:25 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Don't we have a hook for this? Also, probably should be a community tech bug given that it's a gadget...

The code handling this template is the BoiteDeroulante function in MediaWiki:Common.js . It's only called on $( document ).ready(), hence the issue.

The English Wikipedia uses the mw.hook( 'wikipage.content' ) hook for this.

Arkanosis added a subscriber: Trizek.

Fixed.

@Trizek: we probably have the same issue with a bunch of features (most of functions defined in that Common.js, I guess), so please let me know about anything similar you know is not working.

I'll check that file later anyway.