Page MenuHomePhabricator

Update mediawiki/tools/codesniffer repository to use phpcs.xml file
Closed, ResolvedPublic

Description

Instead of having phpcs --standard=./MediaWiki --extensions=php,php5,inc --ignore=vendor,*fail.php -p . in composer.json, we should use the phpcs.xml file.

Event Timeline

Legoktm created this task.Oct 27 2015, 10:51 PM
Legoktm raised the priority of this task from to Low.
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: Legoktm.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2015, 10:51 PM
Haritha28 set Security to None.

@Legoktm: I am currently working on this bug and is it that I have to create a new phpcs.xml file and add the parameters --standard , --extension , --ignore and call the file here.

Yes, those parameters should go in the phpcs.xml file. See how it's setup in https://github.com/wikimedia/mediawiki-extensions-AbsenteeLandlord for example,

Change 263222 had a related patch set uploaded (by Haritha28):
Update mediawiki/tools/codesniffer with phpcs.xml

https://gerrit.wikimedia.org/r/263222

Change 263222 merged by jenkins-bot:
build: Add and use phpcs.xml

https://gerrit.wikimedia.org/r/263222

Legoktm closed this task as Resolved.Jan 19 2016, 7:24 AM