codesniffer repository to use phpcs.xml file
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Oct 27 2015, 10:51 PM

Description

Instead of having phpcs --standard=./MediaWiki --extensions=php,php5,inc --ignore=vendor,*fail.php -p . in composer.json, we should use the phpcs.xml file.

Details

	Subject	Repo	Branch	Lines +/-
	build: Add and use phpcs.xml	mediawiki/tools/codesniffer	master	+9 -1

Customize query in gerrit

Event Timeline

Legoktm created this task.Oct 27 2015, 10:51 PM

Legoktm raised the priority of this task from to Low.

Legoktm updated the task description. (Show Details)

Legoktm added projects: good first task, MediaWiki-Codesniffer.

Legoktm subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2015, 10:51 PM

Haritha28 subscribed.Jan 8 2016, 11:59 AM

Haritha28 claimed this task.Jan 8 2016, 12:14 PM

Haritha28 set Security to None.

@Legoktm: I am currently working on this bug and is it that I have to create a new phpcs.xml file and add the parameters --standard , --extension , --ignore and call the file here.

Yes, those parameters should go in the phpcs.xml file. See how it's setup in https://github.com/wikimedia/mediawiki-extensions-AbsenteeLandlord for example,

Change 263222 had a related patch set uploaded (by Haritha28):
Update mediawiki/tools/codesniffer with phpcs.xml

https://gerrit.wikimedia.org/r/263222

gerritbot added a project: Patch-For-Review.Jan 10 2016, 12:13 PM

Change 263222 merged by jenkins-bot:
build: Add and use phpcs.xml

https://gerrit.wikimedia.org/r/263222

Legoktm closed this task as Resolved.Jan 19 2016, 7:24 AM

Update mediawiki/tools/codesniffer repository to use phpcs.xml file Closed, ResolvedPublicActions

Description

Details

Event Timeline

Update mediawiki/tools/codesniffer repository to use phpcs.xml file
Closed, ResolvedPublic
Actions