Adapt wmf-mariadb101 package for stretch and adapt its service to systemd
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jcrespo
	Oct 28 2015, 11:31 AM

Description

Basically, fully embrace systemd for mariadb instead of using its backwards compatibility layer.

Details

Subject	Repo	Branch	Lines +/-
mariadb: Remove package hacks for MariaDB 10.1 on jessie	operations/puppet	production	+55 -33
mariadb: Improve systemd and package management	operations/software	master	+46 -1
mariadb: Initial stretch support for wmf package with systemd	operations/puppet	production	+7 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T168494 tracking task: jessie -> stretch
Resolved	jcrespo	T168356 Prepare mysql hosts for stretch
Resolved	jcrespo	T116903 Adapt wmf-mariadb101 package for stretch and adapt its service to systemd

Event Timeline

jcrespo created this task.Oct 28 2015, 11:31 AM

jcrespo claimed this task.

jcrespo raised the priority of this task from to Needs Triage.

jcrespo updated the task description. (Show Details)

jcrespo added projects: DBA, SRE.

jcrespo subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2015, 11:31 AM

jcrespo mentioned this in T101516: Upgrade db1022, which has an older kernel.Oct 28 2015, 11:34 AM

jcrespo triaged this task as Low priority.Nov 6 2015, 4:53 PM

jcrespo set Security to None.

I am going to stall it, because official packages do not do it.

jcrespo moved this task from Triage to Backlog on the DBA board.Nov 17 2015, 3:25 PM

This is now possible for 10.1, and I have packages for stretch that do that. We have to decide if to maintain the systemd unit on puppet or on the package.

My two cents: From a high level view I personally prefer the systemd unit to be in the Debian package since it's part of the general package logic. For packages where we anticipate many changes to the unit it sometimes makes sense to manage it rather via puppet, but (after some initial experimentation) I'd expect the systemd unit for wmf-mariadb10 to be fairly static. If add the unit to the package this would also simplify a step-wise migration from sysvinit to systemd by upgrading the package (since the migration requires a restart of mysqld anyway).

we will repurpose this for stretch, we'll keep probably 10.0 on jesssie using inet.d.

jcrespo renamed this task from Adapt wmf-mariadb10 package for jessie or puppetize differently its service to adapt it to systemd to Adapt wmf-mariadb101 package for stretch and adapt its service to systemd.May 15 2017, 4:46 PM

we got some progress:

P5501 mariadb 10.1 + stretch + systemd unit progress

1	# dpkg -i wmf-mariadb101_10.1.23-1_amd64.deb
2	Selecting previously unselected package wmf-mariadb101.
3	(Reading database ... 214374 files and directories currently installed.)
4	Preparing to unpack wmf-mariadb101_10.1.23-1_amd64.deb ...
5	Unpacking wmf-mariadb101 (10.1.23-1) ...
6	Setting up wmf-mariadb101 (10.1.23-1) ...
7	update-alternatives: using /opt/wmf-mariadb101/bin/mysql to provide /usr/local/bin/mariadb (mariadb) in auto mode
8	update-alternatives: using /opt/wmf-mariadb101/bin/mysqldump to provide /usr/local/bin/mariadbdump (mariadbdump) in auto mode
9	update-alternatives: using /opt/wmf-mariadb101/bin/mysql to provide /usr/local/bin/mysql (mysql) in auto mode
10	update-alternatives: using /opt/wmf-mariadb101/bin/mysqldump to provide /usr/local/bin/mysqldump (mysqldump) in auto mode
11	update-alternatives: using /opt/wmf-mariadb101/bin/mysqlbinlog to provide /usr/local/bin/mysqlbinlog (mysqlbinlog) in auto mode
12	update-alternatives: using /opt/wmf-mariadb101/bin/mysql_upgrade to provide /usr/local/bin/mysql_upgrade (mysql_upgrade) in auto mode
13	update-alternatives: using /opt/wmf-mariadb101/bin/mysqlcheck to provide /usr/local/bin/mysqlcheck (mysqlcheck) in auto mode
14
15	# systemctl status mariadb
16	● mariadb.service - MariaDB database server
17	Loaded: loaded (/etc/systemd/system/mariadb.service; disabled; vendor preset: enabled)
18	Active: inactive (dead)
19
20	# systemctl status mariadb.service
21	● mariadb.service - MariaDB database server
22	Loaded: loaded (/etc/systemd/system/mariadb.service; disabled; vendor preset: enabled)
23	Active: inactive (dead)
24
25	# apt remove wmf-mariadb101
26	Reading package lists... Done
27	Building dependency tree
28	Reading state information... Done
29	The following package was automatically installed and is no longer required:
30	libssl-doc
31	Use 'apt autoremove' to remove it.
32	The following packages will be REMOVED:
33	wmf-mariadb101
34	0 upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
35	After this operation, 0 B of additional disk space will be used.
36	Do you want to continue? [Y/n] Y
37	(Reading database ... 215121 files and directories currently installed.)
38	Removing wmf-mariadb101 (10.1.23-1) ...
39	update-alternatives: warning: alternative /opt/wmf-mariadb101/bin/mysql (part of link group mariadb) doesn't exist; removing from list of alternatives
40	update-alternatives: warning: /etc/alternatives/mariadb is dangling; it will be updated with best choice
41	update-alternatives: warning: alternative /opt/wmf-mariadb101/bin/mysqldump (part of link group mariadbdump) doesn't exist; removing from list of alternatives
42	update-alternatives: warning: /etc/alternatives/mariadbdump is dangling; it will be updated with best choice
43	update-alternatives: warning: alternative /opt/wmf-mariadb101/bin/mysql (part of link group mysql) doesn't exist; removing from list of alternatives
44	update-alternatives: warning: /etc/alternatives/mysql is dangling; it will be updated with best choice
45	update-alternatives: warning: alternative /opt/wmf-mariadb101/bin/mysqldump (part of link group mysqldump) doesn't exist; removing from list of alternatives
46	update-alternatives: warning: /etc/alternatives/mysqldump is dangling; it will be updated with best choice
47	update-alternatives: warning: alternative /opt/wmf-mariadb101/bin/mysqlbinlog (part of link group mysqlbinlog) doesn't exist; removing from list of alternatives
48	update-alternatives: warning: /etc/alternatives/mysqlbinlog is dangling; it will be updated with best choice
49	update-alternatives: warning: alternative /opt/wmf-mariadb101/bin/mysql_upgrade (part of link group mysql_upgrade) doesn't exist; removing from list of alternatives
50	update-alternatives: warning: /etc/alternatives/mysql_upgrade is dangling; it will be updated with best choice
51	update-alternatives: warning: alternative /opt/wmf-mariadb101/bin/mysqlcheck (part of link group mysqlcheck) doesn't exist; removing from list of alternatives
52	update-alternatives: warning: /etc/alternatives/mysqlcheck is dangling; it will be updated with best choice
53
54	# systemctl status mariadb
55	Unit mariadb.service could not be found.

Some more progress, after removing galera stuff: P5501#29701

I have installed wmf-mariadb101_10.1.23-1_amd64.deb on a fresh stretch to play around with it - will get back to you if I see issues!

I have to package 10.1.24 and fix some things- coming soon.

Change 357626 had a related patch set uploaded (by Jcrespo; owner: Jcrespo):
[operations/software@master] mariadb: Improve systemd and package management

https://gerrit.wikimedia.org/r/357626

gerritbot added a project: Patch-For-Review.Jun 7 2017, 2:56 PM

jcrespo added a parent task: T168356: Prepare mysql hosts for stretch.Jun 20 2017, 6:49 AM

Change 360845 had a related patch set uploaded (by Jcrespo; owner: Jcrespo):
[operations/puppet@production] mariadb: Initial stretch support for wmf package with systemd

https://gerrit.wikimedia.org/r/360845

Change 360845 merged by Jcrespo:
[operations/puppet@production] mariadb: Initial stretch support for wmf package with systemd

https://gerrit.wikimedia.org/r/360845

The currrent package works ok, but there are 2 little details, which I am not 100% sure if to solve as config defaults or as package defaults. 2 options need to change with the new package:

socket     = /var/run/mysqld/mysql.sock
basedir    = /opt/wmf-mariadb101

The first one, because we no longer allow to use /tmp for that. The second because without mysqld_safe, it defaults to look for them on /usr/local. There are some merits on doing it on package, to have working default, but I think they should be on config to allow clearly multi-instance in the future and avoid uninteded bad defaults.

For that, we need basically T148507.

+1 to place it on config rather than in package.
I would prefer to be able to configure it thru puppet instead of hardcoding it in the package. As you already mentioned, the nearest future use case is mult-instance config.

jcrespo added a subtask: Restricted Task.Jun 22 2017, 3:49 PM

Change 357626 merged by Jcrespo:
[operations/software@master] mariadb: Improve systemd and package management

https://gerrit.wikimedia.org/r/357626

I am going to resolve this because technically, the package and systemd are correct- the things missing are the socket and the basedir which we have decided are configuration; but the package can work as it is now as a bare minimum. That doesn't mean we are happy with it, it is just ok to move on and keep improving.

jcrespo removed a subtask: Restricted Task.Jun 22 2017, 7:21 PM

Change 371450 had a related patch set uploaded (by Jcrespo; owner: Jcrespo):
[operations/puppet@production] mariadb: Remove package hacks for MariaDB 10.1 on jessie

https://gerrit.wikimedia.org/r/371450

Change 371450 merged by Jcrespo:
[operations/puppet@production] mariadb: Remove package hacks for MariaDB 10.1 on jessie